Replace AMD nvme workaround from oem-5.10 with upstream version

Can I turn it public?

Yes

It seems that some OEM designs don't have StorageD3enable set in the acpi tables for Renoir.

So we should use this for Cezanne, but may need another quirk elsewhere for RN. So please don't remove the sauce patches until we come up with another idea for them.

OK, I'll wait until it settles down.

Given NVME upstream's reluctance to accept any sort of #ifdef CONFIG_X86 or match against a PCI Renoir device for a quirk, I'm not sure where the right home for that behavior can be done for Renoir without BIOS change.

I am not sure why it's needed? This can be totally done in nvme driver...

It can be, but Christoph wants this out of the NVME driver. It can technically apply to any storage device. So there are other patches that will move it out and add quirk there:
https://patchwork.kernel.org/project/linux-acpi/list/?series=496353

IMO it's a bit over-engineered, but it's up to maintainers to decide...

The other ones for RN and LCN are now in nvme-5.14:
http://git.infradead.org/nvme.git/commit/ddcd52fffc7ecaf9c644fe4cf6f64da31c3e0565
http://git.infradead.org/nvme.git/commit/7c20093d34bcaf6bc1e2fbe44cb665eaa07f8964

Can you please pick up these 3 for oem-5.10 and oem-5.13?

Sending the fix in another SRU.

Looks like other SRU missed #9 still.

Right, I was being sloppy.

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

This bug was fixed in the package linux-oem-5.13 - 5.13.0-1009.10

---------------
linux-oem-5.13 (5.13.0-1009.10) focal; urgency=medium

  * CVE-2021-33909
    - SAUCE: seq_file: Disallow extremely large seq buffer allocations

linux-oem-5.13 (5.13.0-1007.7) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1007.7 -proposed tracker (LP: #1934979)

  * intel_pmc_core driver is not probed on ADL (LP: #1934660)
    - SAUCE: platform/x86: intel_pmc_core: Add Alderlake support to pmc_core
      driver
    - SAUCE: platform/x86: intel_pmc_core: Add Latency Tolerance Reporting (LTR)
      support to Alder Lake
    - SAUCE: platform/x86: intel_pmc_core: Add Alder Lake low power mode support
      for pmc_core
    - SAUCE: platform/x86: intel_pmc_core: Add GBE Package C10 fix for Alder Lake
      PCH

linux-oem-5.13 (5.13.0-1006.6) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1006.6 -proposed tracker (LP: #1934490)

  * Replace AMD nvme workaround from oem-5.10 with upstream version
    (LP: #1930719)
    - ACPI: Check StorageD3Enable _DSD property in ACPI code
    - ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint

  * Add Thunderbolt support for Intel Alder Lake (LP: #1934240)
    - thunderbolt: Add support for Intel Alder Lake

  * Fix Ethernet not working by hotplug - RTL8106E (LP: #1930645)
    - SAUCE: r8169: Use PHY_POLL when RTL8106E enable ASPM

  * Realtek USB hubs in Dell WD19SC/DC/TB fail to work after exiting s2idle
    (LP: #1928242)
    - USB: Verify the port status when timeout happens during port suspend
    - Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"

  * USB Type-C hotplug event not handled properly in TGL-H system during s2idle
    (LP: #1931072)
    - drm/i915: Force a TypeC PHY disconnect during suspend/shutdown

  * Miscellaneous Ubuntu changes
    - [Config] Sync annotations and config with master

  [ Ubuntu: 5.13.0-11.11 ]

  * impish/linux: 5.13.0-11.11 -proposed tracker (LP: #1933854)
  * Packaging resync (LP: #1786013)
    - [Packaging] update variants
  * Support builtin revoked certificates (LP: #1932029)
    - [Packaging] build canonical-revoked-certs.pem from branch/arch certs
    - [Packaging] Revoke 2012 UEFI signing certificate as built-in
    - [Config] Configure CONFIG_SYSTEM_REVOCATION_KEYS with revoked keys
  * Miscellaneous Ubuntu changes
    - [Packaging] Change source package name to linux
  * Miscellaneous upstream changes
    - mm/page_alloc: Correct return value of populated elements if bulk array is
      populated

  [ Ubuntu: 5.13.0-10.10 ]

  * impish/linux-unstable: 5.13.0-10.10 -proposed tracker (LP: #1933795)
  * Pixel format change broken for Elgato Cam Link 4K (LP: #1932367)
    - media: uvcvideo: Fix pixel format change for Elgato Cam Link 4K
  * initramfs-tools & kernel: use zstd as the default compression method
    (LP: #1931725)
    - s390/decompressor: correct BOOT_HEAP_SIZE condition
    - s390/boot: add zstd support
    - [Packaging] use ZSTD to compress s390 kernels
  * Miscellaneous Ubuntu changes
    - SAUCE: selftests: tls: fix chacha+bidir tests
    - SAUCE: selftests: icmp_redirect: support expected failures
    - [Config] update ...

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1930719

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.