AppArmor

parser: misleading file and line number in error report

Bug #588014 reported by Arkadiusz Miśkiewicz on 2010-05-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	AppArmor	Fix Released	Medium	Kees Cook
	2.5	Fix Released	High	Unassigned	AppArmor 2.5.1

Bug Description

I got "AppArmor parser error in /etc/apparmor.d/usr.sbin.httpd.prefork at line 93616: Could not open '(null)'" once (this is lp bug 588012 but that's not important).

The problem is with reported file name and line number in this message.

/etc/apparmor.d/usr.sbin.httpd.prefork contains only 101 lines(!) but it uses #include a lot and it includes quite big file with over 11000 lines. Still, no idea where 93616 came from. Likely because that huge file also does over 1300 #includes which in total, if concatenate all that includes files could be so big as almost 100 000 lines.

Anyway apparmo parser should be smarter and report correct file name and correct line number.

Related branches

lp://qastaging/apparmor/2.12

Revision history for this message

Arkadiusz Miśkiewicz (arekm) wrote on 2010-05-31:

That was Apparmor parser 2.5 of course aka latest "mature".

Revision history for this message

Kees Cook (kees) wrote on 2010-06-05:

Thanks for the reminder! Yes, this has been a problem since the parser was refactored to handle includes internally. Commit 1413 should fix this in future releases.

Changed in apparmor:
status:	New → Fix Committed
importance:	Undecided → Medium
assignee:	nobody → Kees Cook (kees)
milestone:	none → 2.5.1