Autopilot-qt does not meet DBus protocol specification
Bug #1214128 reported by
Thomi Richards
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Autopilot Qt Support |
Fix Committed
|
Medium
|
Unassigned | ||
Bug Description
The autopilot DBus wire protocol specification says that each object should be exported as a structure consisting of two parts: the object path, and the state dictionary.
Autopilot-qt currently exports each object as a dbus array of two parts, instead of a dbus structure of two parts. This still works in autopilot, but should reallly be fixed, for consistency.
Related branches
lp://qastaging/~autopilot/autopilot-qt/experimental
- PS Jenkins bot: Approve (continuous-integration)
- Autopilot Hackers: Pending requested
-
Diff: 1194 lines (+610/-161)15 files modifieddebian/changelog (+7/-0)
debian/control (+4/-2)
driver/autopilot_types.h (+26/-0)
driver/dbus_adaptor.cpp (+1/-1)
driver/dbus_object.cpp (+4/-2)
driver/driver.pro (+2/-1)
driver/introspection.cpp (+62/-25)
driver/introspection.h (+1/-1)
driver/qtnode.cpp (+125/-50)
driver/qtnode.h (+29/-8)
driver/qttestability.cpp (+3/-0)
driver/rootnode.cpp (+15/-26)
driver/rootnode.h (+2/-4)
tests/unittests/tst_introspection.cpp (+326/-39)
tests/unittests/unittests.pro (+3/-2)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in autopilot-qt: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Fix committed into lp:autopilot-qt at revision 71, scheduled for release in autopilot-qt, milestone Unknown