Dash - Left clicking on purchasable/installable content should open a preview
Bug #1045230 reported by
John Lea
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
High
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
unity-lens-applications (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
unity-lens-music (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity-lens-shopping (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Left clicking on a on purchasable/
- left clicking on a app under 'App available to download' category header should open a preview
- left clicking on a song or album under 'More suggestions' category header in the Music Lens should open a preview
- left clicking on a product under 'More suggestions' category header in the Dash Home should open a preview
(of course right clicking should also open a preview)
Note: bug reverted to Triaged, as it seems like this fix has regressed.
Related branches
lp://qastaging/~nicolas-doffay/unity/preview-click-exit
- Neil J. Patel (community): Approve
- Nick Dedekind: Pending requested
-
Diff: 116 lines (+33/-4)6 files modifieddash/CoverflowResultView.cpp (+5/-3)
dash/previews/MusicPreview.cpp (+1/-0)
dash/previews/Preview.cpp (+8/-0)
dash/previews/Preview.h (+2/-0)
dash/previews/PreviewContainer.cpp (+15/-0)
dash/previews/PreviewContainer.h (+2/-1)
lp://qastaging/~stolowski/unity-lens-applications/preview-on-lmb
- Michal Hruby (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 57 lines (+22/-11)1 file modifiedsrc/daemon.vala (+22/-11)
lp://qastaging/~stolowski/unity-lens-music/preview-on-lmb
- Michal Hruby (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 54 lines (+21/-11)2 files modifiedsrc/musicstore-scope.vala (+20/-11)
tests/manual/previews-musicstore.txt (+1/-0)
lp://qastaging/~stolowski/unity-lens-shopping/preview-on-lmb
- Michal Hruby (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 31 lines (+9/-1)2 files modifiedsrc/scope.vala (+8/-0)
tests/manual-tests/shopping-lens-tests.txt (+1/-1)
tags: | added: dashm udp |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
Changed in unity: | |
importance: | Undecided → High |
Changed in ayatana-design: | |
importance: | Undecided → High |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in ayatana-design: | |
status: | New → Triaged |
Changed in unity: | |
status: | New → Triaged |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
milestone: | none → backlog |
Changed in unity-lens-applications: | |
importance: | Undecided → High |
assignee: | nobody → Pawel Stolowski (stolowski) |
no longer affects: | unity |
Changed in unity-lens-applications: | |
status: | New → In Progress |
Changed in unity: | |
importance: | Undecided → High |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
status: | New → Confirmed |
Changed in unity: | |
assignee: | Nick Dedekind (nick-dedekind) → Nicolas d'Offay (nicolas-doffay) |
Changed in unity: | |
status: | Confirmed → Fix Committed |
milestone: | none → 7.0 |
Changed in unity: | |
milestone: | 7.0 → 6.6 |
Changed in unity-lens-applications: | |
status: | In Progress → Invalid |
no longer affects: | unity-lens-applications |
Changed in unity: | |
status: | Fix Committed → Fix Released |
no longer affects: | unity/6.0 |
Changed in unity: | |
assignee: | Nicolas d'Offay (nicolas-doffay) → nobody |
Changed in ayatana-design: | |
importance: | High → Critical |
Changed in unity (Ubuntu): | |
importance: | High → Critical |
importance: | Critical → High |
importance: | High → Critical |
status: | Fix Released → Triaged |
Changed in unity: | |
importance: | High → Critical |
status: | Fix Released → Triaged |
description: | updated |
Changed in unity-lens-applications (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Critical |
summary: |
- Dash - Left clicking on a 'App available to download' should open a + Dash - Left clicking on purchasable/installable content should open a preview |
description: | updated |
description: | updated |
Changed in unity: | |
importance: | Critical → High |
Changed in unity (Ubuntu): | |
importance: | Critical → High |
Changed in unity-lens-applications (Ubuntu): | |
importance: | Critical → High |
Changed in unity: | |
status: | Triaged → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in unity: | |
milestone: | 6.6 → 7.0.0 |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in application lens by responding with SHOW_PREVIEW on activate() call for installable apps; this however is not correctly handled in unity (preview is displayed correctly, but has broken next/prev navigation), so a fix is also needed in unity.