Dash - update Dash keyboard shortcuts so the 'CTRL + TAB' switches between Lenses and 'TAB' by itself moves the focus between categories
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
High
|
Andrea Azzarone | ||
Unity Distro Priority |
Fix Released
|
Undecided
|
Unassigned | ||
unity-2d |
Fix Released
|
High
|
Albert Astals Cid | ||
unity (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone | ||
Precise |
Fix Released
|
Undecided
|
Unassigned | ||
unity-2d (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Precise |
Fix Released
|
High
|
Bartosz Kosiorek |
Bug Description
Test case:
1. Open the dash
-> "CTRL + TAB" and "CTRL + PAGEDOWN" should switch the user between lenses, in a left to right order
-> "CTRL + SHIFT + TAB" and "CTRL + PAGEUP" should switch the user between lenses, in a right to left order.
-> TAB should jump the keyboard focus between the search result category headers and (if the search filters are open) between the "All" button at the top of each search filter category header.
-> If no item on the dash is currently in focus, pressing TAB should focus the top category header.
-> If a item is already focused, pressing TAB should focus the next category header below.
-> If the item focused is either in the last search result category header, or (if the search filters are open), a button under the last search filter category header, pressing TAB should jump the focus back to the first search result category header.
-> If the search filters are open and the item in the last search result category header is selected, pressing TAB should focus the "All" button to the right of the top search filter category header.
===
Dash - update Dash keyboard shortcuts so the 'CTRL + TAB' switches between Lenses and 'TAB' by itself moves the focus between categories.
Requested change:
- When the Dash is open, "CTRL + TAB" and "CTRL + PAGEDOWN" should switch the user between lenses, in a left to right order.
- When the Dash is open, "CTRL + SHIFT + TAB" and "CTRL + PAGEUP" should switch the user between lenses, in a right to left order.
- When the Dash is open, TAB should jump the keyboard focus between the search result category headers and (if the search filters are open) between the "All" button at the top of each search filter category header.
- If no item on the dash is currently in focus, pressing TAB should focus the top category header.
- If a item is already focused, pressing TAB should focus the next category header below.
- If the item focused is either in the last search result category header, or (if the search filters are open), a button under the last search filter category header, pressing TAB should jump the focus back to the first search result category header.
- If the search filters are open and the item in the last search result category header is selected, pressing TAB should focus the "All" button to the right of the top search filter category header.
* when implementing this bug, also review bug https:/
Related branches
- Albert Astals Cid (community): Disapprove
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- jenkins (community): Disapprove (continuous-integration)
- Lohith D Shivamurthy (community): Needs Fixing
-
Diff: 108 lines (+74/-0)2 files modifiedplaces/LensBar.qml (+61/-0)
places/dash.qml (+13/-0)
- John Lea (community): Approve (design)
- Tim Penhey (community): Approve
-
Diff: 1829 lines (+614/-261)34 files modifiedplugins/unityshell/src/DashView.cpp (+128/-14)
plugins/unityshell/src/DashView.h (+3/-1)
plugins/unityshell/src/FilterAllButton.h (+1/-0)
plugins/unityshell/src/FilterBar.cpp (+25/-6)
plugins/unityshell/src/FilterBar.h (+10/-2)
plugins/unityshell/src/FilterBasicButton.cpp (+12/-0)
plugins/unityshell/src/FilterBasicButton.h (+0/-2)
plugins/unityshell/src/FilterExpanderLabel.cpp (+55/-16)
plugins/unityshell/src/FilterExpanderLabel.h (+13/-3)
plugins/unityshell/src/FilterFactory.cpp (+2/-2)
plugins/unityshell/src/FilterFactory.h (+3/-1)
plugins/unityshell/src/FilterGenreButton.h (+1/-1)
plugins/unityshell/src/FilterMultiRangeButton.cpp (+2/-1)
plugins/unityshell/src/FilterMultiRangeButton.h (+1/-2)
plugins/unityshell/src/FilterMultiRangeWidget.cpp (+1/-1)
plugins/unityshell/src/FilterRatingsButton.cpp (+99/-22)
plugins/unityshell/src/FilterRatingsButton.h (+11/-0)
plugins/unityshell/src/FilterWidget.cpp (+0/-39)
plugins/unityshell/src/FilterWidget.h (+0/-48)
plugins/unityshell/src/LensBar.cpp (+4/-11)
plugins/unityshell/src/LensBar.h (+0/-1)
plugins/unityshell/src/LensBarIcon.cpp (+1/-0)
plugins/unityshell/src/LensView.cpp (+48/-5)
plugins/unityshell/src/LensView.h (+7/-3)
plugins/unityshell/src/PlacesGroup.cpp (+48/-39)
plugins/unityshell/src/PlacesGroup.h (+2/-0)
plugins/unityshell/src/PreviewBase.h (+0/-2)
plugins/unityshell/src/PreviewBasicButton.h (+0/-1)
plugins/unityshell/src/ResultViewGrid.cpp (+22/-13)
plugins/unityshell/src/SearchBar.cpp (+34/-15)
plugins/unityshell/src/SearchBar.h (+1/-0)
standalone-clients/CMakeLists.txt (+0/-3)
tests/autopilot/autopilot/emulators/unity/dash.py (+26/-0)
tests/autopilot/autopilot/tests/test_dash.py (+54/-7)
- Gerry Boland (community): Approve
-
Diff: 508 lines (+334/-2)12 files modifiedlibunity-2d-private/src/focuspath.cpp (+35/-1)
libunity-2d-private/src/focuspath.h (+6/-0)
shell/dash/Dash.qml (+32/-0)
shell/dash/Filter.qml (+3/-0)
shell/dash/FilterCheckoption.qml (+4/-0)
shell/dash/FilterLoader.qml (+6/-0)
shell/dash/FilterPane.qml (+44/-0)
shell/dash/LensView.qml (+24/-0)
shell/dash/ListViewWithHeaders.qml (+51/-1)
shell/dash/ListViewWithScrollbar.qml (+20/-0)
shell/dash/RendererGrid.qml (+8/-0)
tests/manual-tests/dash.txt (+101/-0)
description: | updated |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → High |
status: | New → Triaged |
Changed in unity: | |
milestone: | none → backlog |
status: | New → Confirmed |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
tags: | added: udp |
Changed in unity (Ubuntu): | |
importance: | Undecided → High |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity-2d: | |
status: | New → Confirmed |
Changed in unity-2d (Ubuntu): | |
status: | New → Confirmed |
Changed in unity-2d: | |
importance: | Undecided → High |
Changed in unity-2d (Ubuntu): | |
importance: | Undecided → High |
description: | updated |
tags: | added: keybinding |
Changed in unity: | |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
assignee: | nobody → Andrea Azzarone (andyrock) |
status: | Confirmed → In Progress |
description: | updated |
Changed in unity: | |
milestone: | backlog → 5.2.0 |
milestone: | 5.2.0 → 5.0.0 |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity-distro-priority: | |
status: | New → Fix Committed |
Changed in unity: | |
milestone: | 5.2.0 → 5.4.0 |
Changed in unity: | |
milestone: | 5.4.0 → 5.6.0 |
tags: | added: distro-priority |
Changed in ayatana-design: | |
importance: | High → Critical |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity-distro-priority: | |
status: | Fix Committed → Fix Released |
Changed in unity-2d: | |
milestone: | none → 5.8 |
Changed in unity-2d: | |
milestone: | 5.8 → 5.10.0 |
description: | updated |
Changed in unity-2d: | |
milestone: | 5.10.0 → 5.12 |
Changed in unity-2d: | |
assignee: | nobody → Albert Astals Cid (aacid) |
status: | Confirmed → In Progress |
Changed in unity-2d: | |
status: | In Progress → Fix Committed |
Changed in unity-distro-priority: | |
status: | Fix Released → Fix Committed |
tags: | added: reviewedbydesignp |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
status: | Fix Released → Fix Committed |
tags: | removed: reviewedbydesignp |
Changed in unity-2d (Ubuntu): | |
status: | Confirmed → Fix Committed |
description: | updated |
Changed in unity (Ubuntu Precise): | |
status: | New → Fix Released |
Changed in unity-2d: | |
status: | Fix Committed → Fix Released |
Changed in unity-2d (Ubuntu Precise): | |
assignee: | nobody → Bartosz Kosiorek (gang65) |
importance: | Undecided → High |
tags: |
added: verification-donedistro-priority removed: distro-priority verification-needed |
tags: |
added: distro-priority verification-done removed: verification-donedistro-priority |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: | removed: udp |
Changed in unity-distro-priority: | |
status: | Fix Committed → Fix Released |
We have an issue that ctrl-pgup/dn is used for switching tabs in some
places, and ctrl-tab in others. We need to resolve that for consistency
across all applications that offer tabs.
Mark