networking-bgpvpn

bagpipe: revisit driver now that ML2 callback notifications are fixed

Bug #1576440 reported by Thomas Morin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
Fix Released
Low
Thomas Morin
networking-bgpvpn 5.0.0 "newton"

Bug Description

https://review.openstack.org/#/c/273274/ has merged a while back and we should revisit bagpipe driver code that had been written to workaround the fact that on a update_port the notification that we would receive would not contain all information (in particular would not contain host information)

See original description
Tags: bagpipe rfe
Thomas Morin (tmmorin-orange)
Changed in bgpvpn:
importance: Undecided → Medium
status: New → Confirmed
Thomas Morin (tmmorin-orange)
tags: added: bagpipe
Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
milestone: none → 5.0.0
Revision history for this message
Mathieu Rohon (mathieu-rohon) wrote :

Thomas, any news about this bug? should we move it to ocata?

Thomas Morin (tmmorin-orange)
Changed in bgpvpn:
importance: Medium → Low
Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
milestone: 5.0.0 → 6.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/380363

Changed in bgpvpn:
assignee: nobody → Thomas Morin (tmmorin-orange)
status: Confirmed → In Progress
Thomas Morin (tmmorin-orange)
description: updated
summary: - bagpipe: revisit driver now that update notification are fixed
+ bagpipe: revisit driver now that ML2 callback notifications are fixed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/381149

Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
milestone: 6.0.0 → 5.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/380363
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=16711012f26625efe3f6901128780251f0ae18b3
Submitter: Jenkins
Branch: master

commit 16711012f26625efe3f6901128780251f0ae18b3
Author: Thomas Morin <email address hidden>
Date: Fri Sep 30 16:52:27 2016 +0200

    bagpipe: port+orig_port are in Port AFTER_UPDATE callbacks

    ML2 code has for some time now been updated to provide both port and
    original port information in Port AFTER_UPDATE notifications, in all
    code paths.

    We can thus simplify bagpipe driver and remove now-useless workarounds.

    Change-Id: Ic46234261988ef8ec696e4788f1350e7a6608239
    Partial-Bug: 1576440

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/381149
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=9073ba02c86ae12d7e29e2d7f81ea603ed09e4bf
Submitter: Jenkins
Branch: master

commit 9073ba02c86ae12d7e29e2d7f81ea603ed09e4bf
Author: Thomas Morin <email address hidden>
Date: Mon Oct 3 16:01:42 2016 +0200

    bagpipe: rely on Port AFTER_DELETE callbacks

    Now that ML2-generated Port AFTER_UPDATE registry notifications have
    complete port information, we can use the AFTER_DELETE callbacks, which is
    the right moment to react on Port deletion.

    Change-Id: I84fb6fc63de03ffcba9c1d0ef2772d31429a6031
    Partial-Bug: 1576440

Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.