Breezy

brz export broken when using lp: and (implicit) https scheme

Bug #2008103 reported by Paride Legovini
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Breezy
Fix Released
High
Jelmer Vernooij
Breezy 3.3.3
breezy (Ubuntu)
Fix Released
High
Unassigned

Bug Description

On a Lunar system, i.e. on:

test@stramonio:~$ bzr --version
Breezy (brz) 3.3.2
  Python interpreter: /usr/bin/python3 3.11.1
  Python standard library: /usr/lib/python3.11
  Platform: Linux-6.1.0-14-generic-x86_64-with-glibc2.36
  breezy: /usr/lib/python3/dist-packages/breezy
  Breezy configuration: /home/test/.bazaar
  Breezy log file: /home/test/.cache/breezy/brz.log

with no configuration:

test@stramonio:~$ ls ~/.bazaar
ls: cannot access '/home/test/.bazaar': No such file or directory

this fails:

test@stramonio:~$ bzr export usit lp:ubuntu-test-cases/desktop/testsuites/usit
brz: ERROR: Invalid url supplied to transport: "Unknown Launchpad path: ubuntu-test-cases/desktop/testsuites/usit"

On Jammy, i.e.

ubuntu@paride-j:~$ bzr --version
Breezy (brz) 3.2.1
  Python interpreter: /usr/bin/python3 3.10.6
  Python standard library: /usr/lib/python3.10
  Platform: Linux-6.1.0-14-generic-x86_64-with-glibc2.35
  breezy: /usr/lib/python3/dist-packages/breezy
  Breezy configuration: /home/ubuntu/.config/breezy
  Breezy log file: /home/ubuntu/.cache/breezy/brz.log

it works just fine:

ubuntu@paride-j:~$ bzr export usit lp:ubuntu-test-cases/desktop/testsuites/usit
You have not informed bzr of your Launchpad ID, and you must do this to
write to Launchpad or access private data. See "bzr help launchpad-login".
ubuntu@paride-j:~$ ls -ld usit
drwxrwxr-x 16 ubuntu ubuntu 18 Feb 22 14:07 usit

Looks like more fallback from the new way of handling schemes.

Related branches

lp://qastaging/~jelmer/brz/launchpad-nested
Jelmer Vernooij: Approve
Diff: 33 lines (+11/-4)
1 file modified
breezy/plugins/launchpad/lp_directory.py (+11/-4)
Revision history for this message
Sebastien Bacher (seb128) wrote :

one workaround is to use lp+bzr: instead of lp:

Paride Legovini (paride)
Changed in breezy (Ubuntu):
importance: Undecided → High
Revision history for this message
Paride Legovini (paride) wrote :

This bug affects the many places where files are pulled from Launchpad public repositories in automation or by scripts using `bzr branch lp:project` and `bzr export [...] lp:project` commands with no extra configuration. This relies on lp: translating info a working unauthenticated https request.

@jelmer do you have a fix in mind for this? If a fix in the short term is not planned, what do you think about the possibility of downgrading breezy in Ubuntu via a "+really" upload? There are probably some Python 3.11 compatibility issues to addresses, but it should be doable,.

Jelmer Vernooij (jelmer)
Changed in brz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 3.3.3
The Breezy Bot (the-breezy-bot)
Changed in brz:
status: Triaged → Fix Committed
Revision history for this message
Paride Legovini (paride) wrote :

Thanks Jelmer for the fix! Given the state of the Debian freeze, do you plan to do an upload to Debian ~soon, or will you wait for the next development cycle to open?

If you are not planning to upload to Debian, I'd like to cherry-pick the fix for the bug and upload it to Lunar. Are you fine with this plan, or do you have anything different in mind?

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 2008103] Re: brz export broken when using lp: and (implicit) https scheme

On Mon, Apr 03, 2023 at 02:05:56PM -0000, Paride Legovini wrote:
> Thanks Jelmer for the fix! Given the state of the Debian freeze, do you
> plan to do an upload to Debian ~soon, or will you wait for the next
> development cycle to open?
>
> If you are not planning to upload to Debian, I'd like to cherry-pick the
> fix for the bug and upload it to Lunar. Are you fine with this plan, or
> do you have anything different in mind?

I don't have plans to do an extra upload to Debian, it's simply too time-consuming for
the severity of the bug. Happy for you to cherry-pick this change in Ubuntu though, I
think that makes sense.

Cheers,

Jelmer

Revision history for this message
Paride Legovini (paride) wrote :

All good, thanks. I am preparing a Lunar upload.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package breezy - 3.3.2-2ubuntu1

---------------
breezy (3.3.2-2ubuntu1) lunar; urgency=medium

  * Fix handling of subpaths in lp: URLs.
    Via new patch: d/p/20_fix_handling_of_subpaths_in_lp_urls
    (LP: #2008103)

 -- Paride Legovini <email address hidden> Mon, 03 Apr 2023 18:54:09 +0200

Changed in breezy (Ubuntu):
status: New → Fix Released
Jelmer Vernooij (jelmer)
Changed in brz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.