improper error when cython is missing

Bug #2039710 reported by Robert Collins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Breezy
Triaged
Medium
Unassigned

Bug Description

1) clone git
2) pip installed setuptools_rust and setuptools_gettext
3) make

Copying rust artifact from target/debug/brz to brz
building 'breezy.bzr._static_tuple_c' extension
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -fPIC -I/usr/include/python3.9 -c breezy/bzr/_static_tuple_c.c -o build/temp.linux-x86_64-cpython-39/breezy/bzr/_static_tuple_c.o
breezy/bzr/_static_tuple_c.c:29:10: fatal error: _simple_set_pyx_api.h: No such file or directory
   29 | #include "_simple_set_pyx_api.h"
      | ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
make: *** [Makefile:41: extensions] Error 1

Revision history for this message
Robert Collins (lifeless) wrote :

figured it out - was missing cython3 package. Something in the build order has changed and the logic in setup.py to give a clean error in this situation is getting bypassed.

Revision history for this message
Jelmer Vernooij (jelmer) wrote (last edit ): Re: no proper error when cython is missing

Hey Robert!

We've done a bit of refactoring of setup.py recently - in particular, moving metadata to pyproject.toml and factoring out setuptools-gettext and using setuptools-rust. That probably broke the error message when cython is missing.

Changed in brz:
status: New → Triaged
summary: - build failure in master
+ no proper error when cython is missing
summary: - no proper error when cython is missing
+ improper error when cython is missing
Jelmer Vernooij (jelmer)
Changed in brz:
importance: Undecided → Medium
milestone: none → 4.0.0
Revision history for this message
Robert Collins (lifeless) wrote :

Yah, its a very corner case thing, not surprising to have it break

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.