OpenSRF

Cross Origin Resource Sharing (CORS) Support

Bug #1002028 reported by nivardus on 2012-05-20

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenSRF	Fix Released	Wishlist	Unassigned	OpenSRF 2.4.0-alpha

Following an announcement and discussion on the evergreen-dev mailing list ( http://georgialibraries.markmail.org/search/?q=cors#query:cors+page:1+mid:cuvqjauuvmbjzigt+state:results ) I have prepared a pull-request which includes my implementation of Cross Origin Resource Sharing support.

Updated pullrequest is available here: https://github.com/evergreen-library-system/OpenSRF/pull/2
The diff: https://github.com/evergreen-library-system/OpenSRF/pull/2.diff
Notes and detailed information available in the pull-request and commit message.

See original description

Tags:

Revision history for this message

nivardus (nivardus) wrote on 2012-05-22:

I've updated the bug description with new pull request URL.

description:

updated

Revision history for this message

Dan Scott (denials) wrote on 2012-05-26:

In passing, this is a good overview of CORS, to help supplement the spec: http://www.html5rocks.com/en/tutorials/cors/

Revision history for this message

Bill Erickson (berick) wrote on 2012-07-18:

Doing a first pass review of the code...

In the following code:

+ char *host = origin;
+ if ( !strncmp(origin, "http://", 7) )
+ host = origin + 7;

Do we need to add a similar test for "https"?

I have not tested it yet, but the code looks good otherwise. I look forward to testing soon.
Thanks ! --bill

Galen Charlton (gmc) on 2014-02-28

Changed in opensrf:
milestone:	none → 2.4.0-alpha

Revision history for this message

Galen Charlton (gmc) wrote on 2014-08-21:

Pushed to master, along with a follow-up to add support for HTTPS and another one to set Access-Control-Expose-Headers. Thanks, Bennett!

Galen Charlton (gmc) on 2016-02-04

Changed in opensrf:
status:	Fix Committed → Fix Released

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.