Compiz

[GLES] Animations using (grid) deformation don't work at all any more

Bug #1003255 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Medium
Daniel van Vugt

Bug Description

The Magic Lamp animation doesn't animate anything any more in the gles2 branch. The same seems to be true for all other animations that deform the window.

See original description
Tags: gles
Daniel van Vugt (vanvugt)
summary: - [GLES] Default minimize/restore animation doesn't work any more (Magic
- Lamp)
+ [GLES] Magic Lamp animation doesn't work any more
description: updated
Daniel van Vugt (vanvugt)
summary: - [GLES] Magic Lamp animation doesn't work any more
+ [GLES] Animations using (grid) deformation don't work at all any more
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Anyone who ways to try fixing this bug, the relevant code is that which is commented out in: plugins/animation/src/grid.cpp

It needs to be converted to use the GLVertextBuffer API instead of GLWindow::Geometry (which no longer exists).

Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

I could take a look at it after I finish my current task.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, well if you can't easily use GLVertexBuffer as it is, I suspect the next easiest solution is to add moreVertices() type methods to GLVertexBuffer.

The one thing we don't want to do is copy and paste the old GLWindow::Geometry class, as has been done before. We want to use GLVertexBuffer, cleanly.

That all said, I think if anyone has spare time to look at compiz, then please look at the priority bugs instead:
https://launchpad.net/compiz/+milestone/0.9.8.0

Revision history for this message
Nicolas d'Offay (nicolas-doffay) wrote :

Just took a look at the source, I just got a new branch of compiz, I'm not seeing any commented out code in grid.cpp. Could you provide line numbers?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Branch lp:~compiz-linaro-team/compiz/gles2
And just search for "#if 0"

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Actually, I'll do this. Since I've now ported the two other deformation plugins, how hard can it be?...

Changed in compiz:
assignee: Compiz Linaro Team (compiz-linaro-team) → Daniel van Vugt (vanvugt)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed to gles2 at revision 3357.

Needs some improvement though. I probably deleted a little too much code...

Changed in compiz:
status: Triaged → Fix Committed
Daniel van Vugt (vanvugt)
Changed in compiz:
milestone: 0.9.8.0 → none
Daniel van Vugt (vanvugt)
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.