Slow down of autosave due to tasklist update
Bug #1021356 reported by
Jaap Karssenberg
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zim |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Tasklist dialog is updated when a page is indexed on autosave, for large number of tasks in the database (not in the page being saved) this blocks the autosave and causes lag. In addition to that the tasklist dialog is not properly disconnected when it is closed, so opening it several times results in multiple instances, amplifying the issue.
Two fixes needed:
1/ Detach dialog update from indexing - make it asynchronously / update on focus of the dialog / ..
2/ Fix destruction of tasklist dialog
In addition updating of the dialog may be improved.
See discussion in related question for details
| Changed in zim: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
Revision history for this message
| Jaap Karssenberg (jaap.karssenberg) wrote | #1 |
| Changed in zim: | |
| status: | Confirmed → In Progress |
| tags: | added: index |
Revision history for this message
| Jaap Karssenberg (jaap.karssenberg) wrote | #2 |
| Changed in zim: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Committed fix in rev561 that
1/ takes care dialog is properly disconnected
2/ delays update of dialog to "idle" event
This is not a full fix, since the "idle" event can still cause lag in the typing if it takes too long. Would need to make it full asynchronous to get rid of that. But in order to do so we need to create the infrastructure to make the SQLite index thread save (e.g. by assigning it it's own thread).