glmark2 should use standard gnu_dirs waf module

Bug #1027288 reported by Mike Frysinger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glmark2
Fix Released
Medium
Alexandros Frantzis

Bug Description

waf has a standard gnu_dirs module for processing of paths for configure/install. glmark2 should use that rather than open coding its own unique flags.

i pushed a fix here:
http://bazaar.launchpad.net/~vapier/glmark2/glmark2/revision/239

no idea how to get it merged into mainline though ...

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Thanks for looking into this. To request a merge you can go to: https://code.launchpad.net/~vapier/glmark2/glmark2 and click "Propose for merging" (into trunk). This will start the review process.

Regarding the patch, one problem I see is that supporting just --datadir removes the ability to use arbitrary paths as data paths, which is useful for development. For example, a common workflow for developing glmark2 is to build and run in-tree (without installing) by using --data-path=$(pwd)/data . However, this doesn't work as the code forces the 'glmark2' prefix to all data paths.

One idea is to also keep --data-path (explicit data path) and make it override --datadir (GNU datadir). Another idea is to check if --datadir points to a path that already contains glmark2 data, and if so, not append 'glmark2'. I think I prefer the former, as the latter breaks some assumptions about how GNU datadir works.

Please start the review process (as described in the beginning) and we can continue the discussion there.

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Applied in trunk rev. 243. I changed your patch slightly to also keep --data-path as a way to specify arbitrary data paths, a feature useful for development. Thanks!

Changed in glmark2:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Alexandros Frantzis (afrantzis)
milestone: none → 2012.08
Changed in glmark2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.