ACQ unified search too limiting
Bug #1031535 reported by
Bill Erickson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
2.3 |
Fix Released
|
Undecided
|
Unassigned | ||
2.4 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Seen in Evergreen master/2.3
For example, search for lineitems with a single filter on Invoice -> ID. The results set only includes lineitems that are linked to other invoices. It excludes lineitems that are un-invoiced.
With Lebbeous' assistance, we tracked the culprits down to 1) an INNER JOIN on acqmapinv instead of a LEFT JOIN and, related, a WHERE clause test that looks for NOT (invoice.id = X), which should be changed to (invoice.id != X OR invoice.id IS NULL) to include lineitems that have no invoice linkage.
Code to follow soon.
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
milestone: | 2.4.0-alpha1 → 2.4.0-beta |
Changed in evergreen: | |
milestone: | 2.4.0-beta → 2.4.0-rc |
Changed in evergreen: | |
milestone: | 2.4.0-rc → none |
Changed in evergreen: | |
milestone: | 2.5.0-alpha1 → 2.5.0-alpha2 |
Changed in evergreen: | |
assignee: | nobody → Dan Wells (dbw2) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think one thing that's missing from the above explanation is that the kind of search that has a problem is, "show me lineitems where invoice id is NOT 3."
Here's a patch that works for me, but wants a little more testing so we can be reasonably sure that it doesn't cause any regressions for other queries:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/collab/ senator/ lp1031535