Constrain movement of clips to vertical (Holding CTRL)

Bug #1047050 reported by Andy Finch
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Critical
Unassigned

Bug Description

When moving a clip from one track to another, we need the option to constrain the movement to vertical only. It is far too easy to accidentally move a clip left/right after it is carefully timed.

Related branches

Andy Finch (fincha)
Changed in openshot:
milestone: none → 1.4.3
importance: Undecided → Wishlist
status: New → Fix Committed
Revision history for this message
Andy Finch (fincha) wrote :

This has been committed to the trunk. Hold down 'ALT GR' while dragging the clip to activate. An indicator line that aligns with the clips start position will appear, and the clip will snap to this line when released.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Fixed regression with this patch, that broke saving a project due to the "snap_line" object

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

I changed this quite a bit, to no longer show the snap_line, and completely constrain the horizontal movement while dragging when the CTRL key is pressed (left or right key). I think you will like this behavior better... since it acts more similar to image editors such as Gimp or Inkscape. Just hold the CTRL key, and drag a clip to test this.

Revision history for this message
Andy Finch (fincha) wrote : Re: [Bug 1047050] Re: Constrain vertical movement of clips

Yep that works well. Good idea to use it on transitions too. There is 1
small problem with the key release event, I'll fix that tonight.

Do you have any thoughts on when we should do a string freeze, for
translations? Someone is working on a patch to add some extra configurable
values, but I don't know when they'll complete it. Also, I don't know how
many GTK changes we want to make as it affects the GTK3 work Mael has been
doing.

Cheers,
Andy.

On 7 September 2012 21:40, Jonathan Thomas <email address hidden> wrote:

> I changed this quite a bit, to no longer show the snap_line, and
> completely constrain the horizontal movement while dragging when the
> CTRL key is pressed (left or right key). I think you will like this
> behavior better... since it acts more similar to image editors such as
> Gimp or Inkscape. Just hold the CTRL key, and drag a clip to test this.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1047050
>
> Title:
> Constrain vertical movement of clips
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openshot/+bug/1047050/+subscriptions
>

Revision history for this message
Jonathan Thomas (jonoomph) wrote : Re: Constrain vertical movement of clips

I'm hoping to do a string freeze very soon. I'm just working my way through all the patches and testing everything, and making small adjustments.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Hey, I just applied a patch that fixes something related to this. So, be sure to get latest first, and see if it's still broken. Thanks!

Changed in openshot:
importance: Wishlist → High
summary: - Constrain vertical movement of clips
+ Constrain vertical movement of clips (Holding CTRL)
summary: - Constrain vertical movement of clips (Holding CTRL)
+ Constrain movement of clips to vertical (Holding CTRL)
Changed in openshot:
importance: High → Critical
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.