2.2+ Editing MARC Fixed Fields jumps cursor to marc record

I also noticed an issue when changing the record type. (Right click the record type and select a new one). After changing it, you seem to start losing fixed fields rows and there's no way to get them back without reloading the screen.

Our libs got this issue when entering fields in workflow.
"Jumping cursor to marc record" issue has been caused by loadRecord() function whenever you filled in a fixed filed (with enough length of characters). The loadRecord() will "refresh" the below record table with the new value you just put in, and yes, after that, keep the cursor on the MARC record table. So, we want to put the cursor back to the current field we're editing, right?
Here is solution -> insert once more code line in this file: /openils.var/web/xul/rel_2_3.1/server/cat/marcedit.js
(rel_2_x.y is depending on your version)
Search this function "updateFixedFields (line 816):
   function updateFixedFields (element) {
       var grid = document.getElementById('leaderGrid');
       var recGrid = document.getElementById('recGrid');
       var new_value = element.value;
      // Don't take focus away/adjust the record on partial changes
      var length = element.getAttribute('maxlength');
      if(new_value.length < length) return true;

      var marc_rec = new MARC.Record ({ delimiter : '$', marcxml : xml_record.toXMLString() });
      marc_rec.setFixedField(element.getAttribute('name'), new_value);

      var xml_string = marc_rec.toXmlString();
      xml_record = new XML( xml_string );
      if (xml_record..record[0]) xml_record = xml_record..record[0];
      loadRecord(); //line 830

      document.getElementById(element.getAttribute('id')).select(); <== Insert this code

Save changed.
Clear cache of client, close the current client window, open the new one, and you're good to go with what you want ^^

Here is the patch if someone need it.
I gonna fix another issue relate to this MARC editor also.
Here it is: "the fixed field editor in MARC edit will not allow a field that had data in it to be edited to have no information. Spaces must be added to take up that space-otherwise, it retains the old data."
Should I open another bug?
Simon

Simon, thank you for your patch and your interest in Evergreen.

Before we can include your code in Evergreen, we need you to add a Developer's Certificate of Origin to this bug to indicate that you did indeed write the code and that you have permission to share it with us:

http://evergreen-ils.org/dokuwiki/doku.php?id=contributing#developer_s_certificate_of_origin

If you plan to make regular or even irregular contributions to Evergreen, it would be best if you learn to use the git distributed version control software and that you request access to the working evergreen git repository. More information on how we use git and how to request access to the working repository is here: http://evergreen-ils.org/dokuwiki/doku.php?id=dev:git

> I gonna fix another issue relate to this MARC editor also.
> Here it is: "the fixed field editor in MARC edit will not allow a field that had data in it to be edited to have no information. >Spaces must be added to take up that space-otherwise, it retains the old data."
> Should I open another bug?

Yes, you should open another bug. We like to keep the bug reports limited to a single problem when possible.

Thanks again,
Jason S.

Hi Jason,
I'm glad to be able to contribute back to Evergreen.
About putting mine to the working evergreen git repository, I think I have access already. But I didn't push any into Evergreen working repositories yet. Maybe I'll try to push this now. If something is in wrong format, please check and let me know what I need to fix. (Yes, I am still a newbie in GIT "world" though ^^)
I have a staff meeting now. I will try to create a branch and push it into Evergreen soon.
Thank your for your info, Jason.
Simon.

Pushed this on:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/simonmai/marc_fixed_fields
Please check it ! Tks
Simon.

For those concerning about cataloging and this marc editor issue, you may want to fix the issue in this bug 1152235 also.
Simon.

Hello Simon,

Thanks for this fix! I've tested it, and it works as intended. However, it had me scratching my head for a bit. Is there a reason why your fix is:

document.getElementById(element.getAttribute('id')).select();

rather than simply:

element.select();

?

There could certainly be a reason (which is why I ask), but in quick testing, the simpler element.select() also got the job done.

If you agree, please update your branch, and I can get this in right away.

Thanks,
Dan

Yeah, you're right, Dan.
Here is the new branch with your suggestion:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/simonmai/fix_jump_cursor_marc_editor
Thank you,
Simon.

Looks good, pushed to all targeted branches.

Thanks, Simon!