Glance

SSL tests are fragile and repeat too much code

Bug #1064052 reported by Brian Waldon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Wishlist
Steve Lewis
Glance 2015.1.0 "kilo"

Bug Description

The tests in glance/tests/functional/v1/test_ssl.py were copied directly from glance/tests/functional/v1/test_api.py. They have since gotten out of sync - which is something we shouldn't have to worry about. These tests need to be rewritten to be api version-agnostic and unittest the ssl code specifically, not the API controller code.

Ian Cordasco (icordasc)
Changed in glance:
assignee: nobody → Steve Lewis (steve-lewis)
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148400

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/148400
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=da4b91d684cd72c61089964661dee93e03533a46
Submitter: Jenkins
Branch: master

commit da4b91d684cd72c61089964661dee93e03533a46
Author: Steve Lewis <email address hidden>
Date: Fri Jan 30 21:47:15 2015 -0800

    Rewrite SSL tests

    Old tests did not ensure the valid certificate, and did not only test
    HTTPS. Revised tests are API agnostic, use a certificate valid for
    '127.0.0.1' (old certificate incorrectly had common name of 'Glance CA'
    so could not be validated) through the authority chain, but does not
    duplicate testing of the API. Included the ca.key matching the ca.crt
    as well to simplify generation of a replacement certificate in the
    future.

    Change-Id: Ibe49d82cca9fd0148c60c501bf074c499ada8a29
    Closes-Bug: 1064052

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.