Missing image in service causes traceback when opening
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Medium
|
Phill |
Bug Description
Hello,
arch linux, r2081
1) Add an image to the service.
2) Remove the image from your hard drive.
3) Save the Service.
4) Say "Yes" on the opening dialog "File missing from service"
5) Reopen the service
Result:
A traceback is shown.
Traceback (most recent call last):
File "/home/
self.
File "/home/
serviceItem
File "/home/
self.
File "/home/
path, ImageSource.
File "/home/
image = Image(path, source, background)
File "/home/
self.timestamp = os.stat(
OSError: [Errno 2] Datei oder Verzeichnis nicht gefunden: '/home/
Expected:
Good question. We should show the "red cross" icon. (But I am asking myself why somebody would want to save a service with a missing file? But that probably does not belong here.)
Related branches
- Raoul Snyman: Approve
- Tim Bentley: Approve
- Jonathan Corwin: Pending requested
-
Diff: 187 lines (+77/-47)4 files modifiedopenlp/core/lib/serviceitem.py (+32/-5)
openlp/core/ui/servicemanager.py (+43/-40)
openlp/core/ui/slidecontroller.py (+1/-1)
openlp/plugins/presentations/lib/messagelistener.py (+1/-1)
Changed in openlp: | |
importance: | Undecided → Medium |
Changed in openlp: | |
status: | New → Confirmed |
Changed in openlp: | |
assignee: | nobody → phill (phill-ridout) |
status: | Confirmed → In Progress |
tags: | added: service-manager |
Changed in openlp: | |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → In Progress |
milestone: | none → 2.0 |
Changed in openlp: | |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |