Configure checks for cairo 1.8, but should check for 1.10

Bug #1078863 reported by Carl Allendorph
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
High
Edward Hennessy

Bug Description

origin/master (2d79b9333785dd421ddebbef1b8d) checks for libcairo v 1.8.0 or higher but has dependencies on functionality in libcairo 1.10.0 or higher.

See attached patch.

Tags: build-system
Revision history for this message
Carl Allendorph (callendorph) wrote :
Revision history for this message
Peter TB Brett (peter-b) wrote :

Hi Carl, can you please clarify what 1.10.0 features we are depending on?

Revision history for this message
Carl Allendorph (callendorph) wrote : RE: [Bug 1078863] Re: Configure checks for cairo 1.8, but should check for 1.10

cairo_recording_surface_create and
cairo_recording_surface_ink_events

Were the two that I saw.

-C

Sent from my Verizon Wireless 4G LTE SmartphonePeter TB Brett <email address hidden> wrote:Hi Carl, can you please clarify what 1.10.0 features we are depending
on?

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1078863

Title:
  Configure checks for cairo 1.8, but should check for 1.10

Status in GPL Electronic Design Automation tools:
  New

Bug description:
  origin/master (2d79b9333785dd421ddebbef1b8d) checks for libcairo v
  1.8.0 or higher but has dependencies on functionality in libcairo
  1.10.0 or higher.

  See attached patch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/1078863/+subscriptions

Revision history for this message
Peter TB Brett (peter-b) wrote :

Well, this doesn't affect 1.8.x, fortunately, just the master branch.

It looks like this is thanks to Ed Hennessy. See commit: 39ac4ab6ff834d60c. I'll assign this bug to him -- I'm not convinced that we need to use the cairo_recording API for gsch2pdf... maybe he can figure out what the best option is.

Changed in geda:
assignee: nobody → Edward Hennessy (ehennes)
Changed in geda:
status: New → Confirmed
Revision history for this message
Edward Hennessy (ehennes) wrote :

Carl,

Thank you for your effort and providing a patch.

Cheers,
Ed

Changed in geda:
status: Confirmed → Fix Committed
Revision history for this message
Peter TB Brett (peter-b) wrote :

I'm reopening this bug, because requiring Cairo 1.10.x breaks support for Ubuntu LTS (10.04.4) which is what's running on all the Linux workstations here at the University of Surrey.

Please make sure that gEDA builds and installs with Cairo 1.8.x. Solutions might include: changing gsch2pdf to not use the new API calls; or not building/installing gsch2pdf if the version of Cairo available is not recent enough.

Thanks!

Changed in geda:
importance: Undecided → High
status: Fix Committed → Confirmed
Revision history for this message
Carl Allendorph (callendorph) wrote :

Keep in mind however, that Ubuntu 12.04 LTS will support libcairo2 v 1.10:
http://packages.ubuntu.com/precise/libcairo2

Also - 10.04 LTS's support for the desktop version stops in April of 2013 - so I would imagine most people that want to keep the security updates of an LTS are going to be moving to 12.04.

Revision history for this message
Peter TB Brett (peter-b) wrote :

I'm sure that the University will be moving to 12.04 at some point. However, right now I can't build gEDA on any of our workstations.

Also, in general in gEDA we've liked to use versions of GTK-related libraries that are in line with the version of GTK that we ship. In this case, that would be Cairo 1.8. I note that no-one's actually been able to express why gsch2pdf *needs* to use these particular functions. Are there really no other alternatives?

Revision history for this message
Carl Allendorph (callendorph) wrote :

The recording commands are currently used only to determine the bounding rectangle of all of the objects and then to use this to translate and scale the cairo_t surface object to the appropriate size for the page size that is defined in the configuration file.

Possible solutions at this point could also be to just not scale the print to full size and print as is. Or have a configuration option that allows the user to determine which mode to use.

For the record, I don't really care what version of the library gets used and I'm not advocating one way or the other. I ran into this bug because I was attempting to build on 10.04 LTS so I'm certainly sympathetic to wanting to support major releases.

Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.9.0
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit f2130f3a7946f425c3b8aa03c005c7a5fa15a5fa
http://git.geda-project.org/geda-gaf/commit/?id=f2130f3a7946f425c3b8aa03c005c7a5fa15a5fa

commit f2130f3a7946f425c3b8aa03c005c7a5fa15a5fa
Author: Peter TB Brett <email address hidden>
Commit: Peter TB Brett <email address hidden>

    Revert "Fixed build issue with libcairo requiring >= 1.10"

    This reverts commit 88da3f2b8838fafb6c49281d784f45d796d45bd8.

    Closes-bug: lp-1078863

Changed in geda:
status: Confirmed → Fix Committed
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.