version detection code produces wrong version

Or perhaps the glanceclient git repo shouldn't have 2 tags linked to head (??)

Note this weirdness causes the versioninfo file to be wrong also.

$ cat glanceclient/versioninfo
0.6.0
0.7.0

Your HEAD points at the commit which the 0.6.0 tag also points to. Since 0.7.0 is a superset of 0.6.0, it makes sense for the commit that HEAD resolves to is contained in both tags.

Not saying this isn't weird, just lending a bit of explanation.

Makes a little more sense with the above, perhaps version detection code isn't 100% the best. I can see people checking out tags and wanting to have the version that python thinks its on actually be the tag they are on and not many tags. Thats how i ran into this, was a wtf moment :-P

Yeah - I need to fix the code. Noted. thanks!

Pretty confident this is fixed by https://review.openstack.org/18897

This change broke running unit tests for me. 822 tests fail with an error similar to this:

Traceback (most recent call last):
  File "/home/johannes/openstack/nova/trunk/nova/tests/test_service.py", line 172, in test_init_and_start_hooks
    serv.start()
  File "/home/johannes/openstack/nova/trunk/nova/service.py", line 425, in start
    verstr = version.version_string_with_package()
  File "/home/johannes/openstack/nova/trunk/nova/version.py", line 87, in version_string_with_package
    return version_info.version_string()
  File "/home/johannes/openstack/nova/trunk/nova/openstack/common/version.py", line 63, in version_string
    for part in self.release_string().split('.'):
AttributeError: 'NoneType' object has no attribute 'split'

This does appear to fix the original bug reported by josh in python-glanceclient. It does introduce the 'bug' of ignoring unsigned tags (which all of the python-glanceclient tags happen to be).

pretty sure this is fixed everywhere now. Please reopen if that's not the case.