BAMF

Coverity DEADCODE - CID 10447

Bug #1100554 reported by Product Strategy Coverity Bug Uploader on 2013-01-16

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
BAMF	Fix Released	Medium	Marco Trevisan (Treviño)	BAMF 0.4.0
bamf (Ubuntu)	Fix Released	Undecided	Unassigned
Raring	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

Coverity report bug.

[Test Case]

None, no regressions allowed.

[Regression Potential]

No regression potential.
_
This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 10447
Checker: DEADCODE
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/561.html
File: /tmp/buildd/bamf-0.4.0daily13.01.11/src/bamf-matcher.c
Function: get_open_office_window_hint
Code snippet:
354 return NULL;
355
356 if (g_str_has_suffix (name, "LibreOffice Writer"))
357 {
CID 10447 - DEADCODE
{CovLStrv2{{t{Assigning: {0} {1}= {2}.}{"binary"}{}{""libreoffice""}}}}
358 binary = "libreoffice";
359 parameter = "writer";
360 }
361 else if (g_str_has_suffix (name, "LibreOffice Calc"))
362 {
CID 10447 - DEADCODE
{CovLStrv2{{t{Assigning: {0} {1}= {2}.}{"binary"}{}{""libreoffice""}}}}
363 binary = "libreoffice";

See original description

Tags:

Related branches

lp://qastaging/~3v1n0/bamf/use-libwnck-matching-signals

Merged into lp://qastaging/bamf/0.4 at revision 532

Andrea Azzarone (community): Approve on 2013-04-18

PS Jenkins bot (community): Approve (continuous-integration) on 2013-04-17

Revision history for this message

Product Strategy Coverity Bug Uploader (coverity-uploader) wrote on 2013-01-16: bamf-trunk: /tmp/buildd/bamf-0.4.0daily13.01.11/src/bamf-matcher.c

bamf-trunk: /tmp/buildd/bamf-0.4.0daily13.01.11/src/bamf-matcher.c Edit (453.2 KiB, text/html)

Source file with Coverity annotations.

Changed in bamf:
importance:	Undecided → Medium

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-04-18:

Fix committed into lp:bamf at revision 532, scheduled for release in bamf, milestone 0.4.0

Changed in bamf:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-05-03:

This bug was fixed in the package bamf - 0.4.0daily13.05.02-0ubuntu1

---------------
bamf (0.4.0daily13.05.02-0ubuntu1) saucy; urgency=low

  [ Marco Trevisan (Treviño) ]
  * debian/control:
    - Update the libwnck-3-dev dependency to 3.4.5

  [ Marco Trevisan (Treviño) <mail@3v1n0.net>, Alexandre Abreu ]
  * Webapps launchers have incorrect window matching (pips) (LP:
    #1059475)

  [ Marco Trevisan (Treviño) ]
  * Coverity SECURE_TEMP - CID 10450 (LP: #1100551)
  * Matcher leaks memory when rematching a new desktop file (LP:
    #1169990)
  * Coverity DEADCODE - CID 10447 (LP: #1100554)
  * Coverity REVERSE_INULL - CID 12653 (LP: #1100553)
  * Webapps launchers have incorrect window matching (pips) (LP:
    #1059475)

[ Ubuntu daily release ]
* Automatic snapshot from revision 533
-- Ubuntu daily release <email address hidden> Thu, 02 May 2013 22:59:03 +0000

Changed in bamf (Ubuntu):
status:	New → Fix Released

Timo Jyrinki (timo-jyrinki) on 2013-05-08

description:

updated

Timo Jyrinki (timo-jyrinki) on 2013-05-15

description:

updated

Marco Trevisan (Treviño) (3v1n0) on 2013-05-17

Changed in bamf:
status:	Fix Committed → Fix Released
no longer affects:	bamf/0.4
Changed in bamf (Ubuntu Raring):
status:	New → Fix Released

Revision history for this message

Adam Conrad (adconrad) wrote on 2013-06-25: Please test proposed package

Hello Product, or anyone else affected,

Accepted bamf into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/bamf/0.4.0daily13.06.19~13.04-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags:

added: verification-needed

Christopher Townsend (townsend) on 2013-07-25

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Scott Kitterman (kitterman) wrote on 2013-08-12: Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.