libappindicator

Coverity COPY_PASTE_ERROR - CID 10969

Bug #1102595 reported by Product Strategy Coverity Bug Uploader on 2013-01-21

This bug affects 1 person

	Status	Importance	Assigned to
libappindicator	Fix Released	Medium	Charles Kerr
13.04	Fix Released	Medium	Charles Kerr
libappindicator (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 10969
Checker: COPY_PASTE_ERROR
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/398.html
File: /tmp/buildd/libappindicator-12.10.1/src/app-indicator.c
Function: app_indicator_set_attention_icon_full
Code snippet:
1889 if (self->priv->attention_icon_name) {
1890 g_free (self->priv->attention_icon_name);
1891 }
1892
CID 10969 - COPY_PASTE_ERROR
"g_strdup(icon_name)" looks like the original copy.
1893 self->priv->attention_icon_name = g_strdup(icon_name);
1894 changed = TRUE;
1895 }
1896
1897 if (g_strcmp0(self->priv->att_accessible_desc, icon_desc) != 0) {
1898 if (self->priv->att_accessible_desc) {

Tags:

Related branches

lp://qastaging/~charlesk/libappindicator/fix-test-merge

Merged into lp://qastaging/libappindicator/13.04 at revision 248

Ted Gould (community): Approve on 2013-01-30

PS Jenkins bot (community): Approve (continuous-integration) on 2013-01-29

lp://qastaging/ubuntu/raring/libappindicator

Revision history for this message

Product Strategy Coverity Bug Uploader (coverity-uploader) wrote on 2013-01-21: libappindicator-13.04: /tmp/buildd/libappindicator-12.10.1/src/app-indicator.c

libappindicator-13.04: /tmp/buildd/libappindicator-12.10.1/src/app-indicator.c Edit (372.7 KiB, text/html)

Source file with Coverity annotations.

Changed in libappindicator:
importance:	Undecided → Medium

PS Jenkins bot (ps-jenkins) on 2013-01-30

Changed in libappindicator:
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-02-13:

This bug was fixed in the package libappindicator - 12.10.1daily13.02.13-0ubuntu1

---------------
libappindicator (12.10.1daily13.02.13-0ubuntu1) raring; urgency=low

  [ Mathieu Trudel-Lapierre ]
  * debian/control:
    - Update style: use trailing commas at the end of dependency lists.
    - Reorganize Build-Depends for clarity.
    - Bump Build-Depends on debhelper to (>= 9).
    - Drop Build-Depends on cdbs.
    - Drop old Conflicts, Replaces, Provides for old unsupported upgrade paths.
    - Update Vcs-Bzr, Vcs-Browser and add a notice to uploaders.
    - Add a Pre-Depends on multiarch-support for libappindicator(3-)7.
    - Add xvfb to Build-Depends.
  * debian/compat: bump to compat level 9.
  * debian/rules:
    - Convert from cdbs to debhelper 9.
    - Add and export DPKG_GENSYMBOLS_CHECK_LEVEL.
    - Override dh_autoreconf to run autogen.sh and not call configure.
    - Override dh_auto_test to run tests per-flavor.
  * debian/*.install:
    - Update paths for multiarch and for use with dh9 (remove debian/tmp...)
  * Fix gtkdoc tests and building of the documentation given a separate build
    directory.

[ Chris J Arges ]
* acinclude.m4: Fix python multi-arch include issues.

  [ Mathieu Trudel-Lapierre ]
  * Automatic snapshot from revision 245 (bootstrap):
    - Fix Vala classes not being able to inherit from Indicator (LP: #1065310)

  [ Charles Kerr ]
  * indicators call deprecated glib function g_type_init() (LP:
    #1103087)
  * test-libappindicator-status fails with "Toggle count: 99" (LP:
    #1109128)
  * Coverity COPY_PASTE_ERROR - CID 10969 (LP: #1102595)
  * libappindicator-docs.sgml missing links (LP: #1083425)
  * Coverity INTEGER_OVERFLOW - CID 10970 (LP: #1102589)

  [ Charles Kerr <email address hidden>, Mathieu Trudel-Lapierre <email address hidden>, Michael Terry ]
  * indicators call deprecated glib function g_type_init() (LP:
    #1103087)
  * test-libappindicator-status fails with "Toggle count: 99" (LP:
    #1109128)
  * Coverity INTEGER_OVERFLOW - CID 10970 (LP: #1102589)
  * Coverity COPY_PASTE_ERROR - CID 10969 (LP: #1102595)

[ Mathieu Trudel-Lapierre ]
* Can't inherit from AppIndicator.Indicator in Vala (LP: #1065310)

[ Automatic PS uploader ]
* Automatic snapshot from revision 250
-- Automatic PS uploader <email address hidden> Wed, 13 Feb 2013 02:02:41 +0000

This bug was fixed in the package libappindicator - 12.10.1daily13.02.13-0ubuntu1

---------------
libappindicator (12.10.1daily13.02.13-0ubuntu1) raring; urgency=low

[ Chris J Arges ]
  * acinclude.m4: Fix python multi-arch include issues.

[ Mathieu Trudel-Lapierre ]
  * Automatic snapshot from revision 245 (bootstrap):
    - Fix Vala classes not being able to inherit from Indicator (LP: #1065310)

[ Charles Kerr <charles.kerr@canonical.com>, Mathieu Trudel-Lapierre <mathieu-tl@ubuntu.com>, Michael Terry ]
  * indicators call deprecated glib function g_type_init() (LP:
    #1103087)
  * test-libappindicator-status fails with "Toggle count: 99" (LP:
    #1109128)
  * Coverity INTEGER_OVERFLOW - CID 10970 (LP: #1102589)
  * Coverity COPY_PASTE_ERROR - CID 10969 (LP: #1102595)

[ Mathieu Trudel-Lapierre ]
  * Can't inherit from AppIndicator.Indicator in Vala (LP: #1065310)

[ Automatic PS uploader ]
  * Automatic snapshot from revision 250
 -- Automatic PS uploader <ps-jenkins@lists.canonical.com>   Wed, 13 Feb 2013 02:02:41 +0000