Evergreen

"Download CSV" with no circ history causes Internal Server Error

Bug #1116258 reported by Pasi Kallinen
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.4.0-beta
2.2
Fix Released
Medium
Unassigned
Evergreen 2.2.7
2.3
Fix Released
Medium
Unassigned
Evergreen 2.3.5

Bug Description

* EG master

1) Log in to OPAC
2) Go yo your account and "Check Out History"
3) Click on "Download CSV"
4) If circulation history has no items, *kaboom*.

Apache error log shows:

****
** content() isn't there. Please create me somewhere (like in OpenSRF::DomainObject::oilsMethodException)!
** Error at OpenILS::Utils::CStoreEditor (/usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm), line 432
** Call Stack (5 deep):
** Error::subs (/usr/share/perl5/Error.pm), line 416
** Error::subs (/usr/share/perl5/Error.pm), line 408
** OpenILS::Utils::CStoreEditor (/usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm), line 451
** OpenILS::Utils::CStoreEditor (/usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm), line 800
** Error::subs (/usr/share/perl5/Error.pm), line 416
** Object type was OpenSRF::DomainObject::oilsMethodException
****
****
** content() isn't there. Please create me somewhere (like in OpenSRF::DomainObject::oilsMethodException)!
** Error at OpenILS::Utils::CStoreEditor (/usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm), line 432
** Call Stack (5 deep):
** Error::subs (/usr/share/perl5/Error.pm), line 416
** Error::subs (/usr/share/perl5/Error.pm), line 408
** OpenILS::Utils::CStoreEditor (/usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm), line 451
** OpenILS::Utils::CStoreEditor (/usr/local/share/perl/5.14.2/OpenILS/Utils/CStoreEditor.pm), line 800
** Error::subs (/usr/share/perl5/Error.pm), line 416
** Object type was OpenSRF::DomainObject::oilsMethodException
****
received error : service=open-ils.trigger : method=open-ils.trigger.event.autocreate.by_definition : params=$VAR1 = [103,1,1,undef];
 Exception: OpenSRF::EX::ERROR 2013-02-05T15:39:50 OpenILS::Application::AppUtils /usr/local/share/perl/5.14.2/OpenILS/Application/AppUtils.pm:187 System ERROR: Exception: OpenSRF::DomainObject::oilsMethodException 2013-02-05T15:39:50 OpenSRF::AppRequest /usr/local/share/perl/5.14.2/OpenSRF/AppSession.pm:1064 <500> *** Call to [open-ils.trigger.event.autocreate.by_definition] failed for session [1360071590.40396915.981069976547], thread trace [1]:
Can't call method "Identity" without a package or object reference at /usr/local/share/perl/5.14.2/OpenILS/Application/Trigger.pm line 136.

[Tue Feb 05 15:39:50 2013] [error] [client 127.0.0.1] egweb: Context Loader error: Exception: OpenSRF::EX::ERROR 2013-02-05T15:39:50 OpenILS::WWW::EGWeb /usr/local/share/perl/5.14.2/OpenILS/WWW/EGWeb.pm:102 System ERROR: Call to open-ils.trigger for method open-ils.trigger.event.autocreate.by_definition \n failed with exception: Exception: OpenSRF::EX::ERROR 2013-02-05T15:39:50 OpenILS::Application::AppUtils /usr/local/share/perl/5.14.2/OpenILS/Application/AppUtils.pm:188 System ERROR: Exception: OpenSRF::DomainObject::oilsMethodException 2013-02-05T15:39:50 OpenSRF::AppRequest /usr/local/share/perl/5.14.2/OpenSRF/AppSession.pm:1064 <500> *** Call to [open-ils.trigger.event.autocreate.by_definition] failed for session [1360071590.40396915.981069976547], thread trace [1]:\nCan't call method "Identity" without a package or object reference at /usr/local/share/perl/5.14.2/OpenILS/Application/Trigger.pm line 136.\n\n\n\n : \n, referer: https://localhost/eg/opac/myopac/circ_history

Revision history for this message
Ben Shum (bshum) wrote :

Confirmed, I remember this error being noted in IRC before. Thanks for creating a ticket to track the issue paxed!

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 2.4.0-alpha
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-alpha1 → 2.4.0-beta
Revision history for this message
Ben Shum (bshum) wrote :

My idea is to simply hide the Download CSV button if there is no circ history to speak of.

Trying out branch: working/user/bshum/tpac-hide-download-circ-history

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/tpac-hide-download-circ-history

tags: added: pullrequest
Revision history for this message
Pasi Kallinen (paxed) wrote :

Looks good, and patches the problem... But I'd be happier if the backend didn't die when requesting a non-existent circ history.

Revision history for this message
Pasi Kallinen (paxed) wrote :

My signoff: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/tpac-hide-download-circ-history-signoff

tags: added: signedoff
Revision history for this message
Ben Shum (bshum) wrote :

Probably right paxed, but I think plugging the front end issue is good to get us started.

Thanks for the sign-off, pushed to master, rel_2_3, and rel_2_2.

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.