missing database upgrade scripts in Evergreen 2.3.4

Bug #1134331 reported by Chris Sharp
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

When upgrading from 2.1.1 to 2.3.4, I learned that the following upgrade scripts are missing from the rel_2_3_4 tree:

2.2.2-2.2.3
2.2.3-2.2.4
2.3.3-2.3.4

Without knowing the contents of these scripts (or which numbered scripts should be applied), I am effectively unable to upgrade to 2.3.4.

Tags: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I think this makes a good argument for NOT allowing database changes after a release is made. IMNSHO, database changes should be something that is only done between minor releases and not for bug fixes. Bug fixes that require database changes should not be backported.

I think we seriously need to look at our support policy. I don't think the community is large enough to adequately support the number of releases that we currently do. I don't know how many times I've tried to help people with upgrade script issues in IRC.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Well, I've said this in IRC and I'll repeat it here. We currently have two streams of upgrade scripts: 1) the numbered scripts for individual DB patches and 2) the monolithic version-to-version upgrade scripts. I propose that we use the numbered scripts in a more robust way. Rather than copying and pasting their contents into a large script that can only run in a single thread (I realize the multithreaded postgres is available in 9.2), it would make more sense to have the version-to-version scripts basically have "include" statements (using that metaphorically) that would refer to the numbered scripts, allowing admins to break up parts of the upgrade to run concurrently. Moving to that would also require a knowledge of prerequisites for each numbered script. There may be valid technical reasons why that wouldn't be possible, but it seems that the upgrade dependency tracking has moved in that direction and it might just be time to commit to that direction.

I'm willing to help do that however I can.

Revision history for this message
Wolf Halton (saphil) wrote :

There does not appear to be a change to the database from 2.3.3 to 2.3.4, which might cause confusion, because the pattern is broken.

Revision history for this message
Bill Erickson (berick) wrote :

Hi Wolf, we have stub upgrade scripts for 2.3.3-to-2.3.4 and 2.2.5-to-2.2.6 as of the Evergreen 2.3.5 release.

Revision history for this message
Bill Erickson (berick) wrote :

I've pushed working => user/berick/lp1134331-2.3-missing-upgrade-scripts

It back-ports scripts for 2.2.2-2.2.3and 2.2.3-2.2.4 into the rel_2_3 series.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.3.6
Revision history for this message
Ben Shum (bshum) wrote :

Looks good. Picked to rel_2_3 series and set for the next point release. Thanks all!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.