Evergreen

Unable to retrieve patrons by inactive barcode

Bug #1154235 reported by Michael Peters
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.4.0-beta
2.2
Fix Released
Medium
Unassigned
Evergreen 2.2.7
2.3
Fix Released
Medium
Unassigned
Evergreen 2.3.5

Bug Description

Evergreen 2.3.4. and master
OpenSRF master
Postgres 9.1
Ubuntu 12.04

Beginning, seemingly, sometime in the 2.3 series patrons can no longer be retrieved using inactive barcodes. This was a feature available in previous versions, and was helpful when patrons came in with an old card that they might have previously thought lost.

Previous versions would display the active patron account when attempting to retrieve by an inactive barcode.

This can be tested by replacing the barcode of a user via the patron editor, and then attempting to retrieve that patron by the old barcode. This results in "Barcode not found." errors, rather than displaying the account associated with the active barcode.

Revision history for this message
Thomas Berezansky (tsbere) wrote :

I was under the impression that this was desired, but that inactive barcodes still come up in patron search?

Revision history for this message
Michael Peters (mrpeters) wrote :

Thomas, I'm not sure. Personally, I liked the old operation and the customer in this case does as well.

How about a YAOUS to toggle the behavior?

Revision history for this message
Jason Etheridge (phasefx) wrote : Re: [Bug 1154235] Re: Unable to retrieve patrons by inactive barcode

FWIW, the original intention was to allow retrieval of patrons with
inactive cards, but deny circulation if such a card was used.

Revision history for this message
Thomas Berezansky (tsbere) wrote :

Easier said than done in some regards...

This ties into barcode autocompletion at this point, in both "load patron by barcode" and "checkout". I personally don't think that should trigger on inactive barcodes if active ones match, regardless of any new YAOUS. Making barcode autocompletion only see inactive cards on exact match is possible, though. I just don't agree with making it happen.

Note that inactive barcodes are now also not valid for SIP2, so they won't work at SIP2 based selfchecks either.

Revision history for this message
Michael Peters (mrpeters) wrote :

Thanks to the help from Thomas, I think we've got a workable solution:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters/allow_inactive_retrieve

tags: added: pullrequest
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-beta
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Ben Shum (bshum) wrote :

Confirmed behavior (didn't notice at first because apparently I've made a local customization to do this already...)

Pushed to master, rel_2_3 and rel_2_2 to restore behavior. Thanks tsbere and mrpeters!

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.