Evergreen

PasswordReset.pm should be removed from existence

Bug #1155478 reported by Pasi Kallinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 2.5.0-alpha2

Bug Description

*EG master

PasswordReset.pm uses a strange home-cooked version of "message catalog" for i18n. These strings are not picked up for translation.

Tags: pullrequest
Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
Revision history for this message
Dan Scott (denials) wrote :

In a non-JSPAC world, I think the i18n in PasswordReset.pm is no longer a factor, if I'm reading opac/password_reset.tt2 correctly.

Revision history for this message
Dan Scott (denials) wrote :

I offer http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/remove_old_password_reset to remove the old, JSPAC-oriented PasswordReset.pm and to streamline our Apache services and make there be one less set of i18n strings to worry about.

Dan Scott (denials)
Changed in evergreen:
milestone: none → 2.5.0-alpha1
tags: added: pullrequest
summary: - PasswordReset.pm uses home-cooked i18n
+ PasswordReset.pm should be removed from existence
Remington Steed (rjs7)
Changed in evergreen:
milestone: 2.5.0-alpha1 → 2.5.0-alpha2
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
Revision history for this message
Bill Erickson (berick) wrote :

Looks good. make check is happy. pushed to master. Thanks Dan, thanks Pasi.

Changed in evergreen:
status: Triaged → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.