Gwich'in language typo

Bug #1158206 reported by Pasi Kallinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.3
Fix Released
Undecided
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

*EG master

(169, 'item_lang', 'gwi', oils_i18n_gettext('169', 'Gwich', 'ccvm', 'value''in')),

The language is "Gwich'in" - the "'in" is in wayy wrong place.

Revision history for this message
Pasi Kallinen (paxed) wrote :

Derp. In file Open-ILS/src/sql/Pg/950.data.seed-values.sql, of course.

Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
milestone: none → 2.4.0-rc
Pasi Kallinen (paxed)
summary: - Gwitch'in language typo
+ Gwich'in language typo
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → 2.5.0-alpha
Revision history for this message
Dan Wells (dbw2) wrote :

I know this is a simple change, but still removing milestone pending a branch and pullrequest.

Changed in evergreen:
milestone: 2.5.0-m1 → none
Revision history for this message
Pasi Kallinen (paxed) wrote :

Fixed in branch user/paxed/lp1158206

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.5.0-m2
Revision history for this message
Remington Steed (rjs7) wrote :

Tested by updating the item_lang coded value on our test server, using the syntax in the provided branch. Works as expected. Rebased to master, signed off. Thanks Pasi!

user/rsteed/lp1158206_gwichin

Revision history for this message
Ben Shum (bshum) wrote :

Works for me too, so I signed off in my working branch and added a new commit to handle the upgrade script to set the value properly in existing installations.

See: user/bshum/lp1158206_gwichin

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1158206_gwichin

Revision history for this message
Dan Wells (dbw2) wrote :

I pushed this, but the upgrade script it also missing the oils_i18n_gettext() call (similar to the other recently pushed branch). Will test and push a fix shortly.

Revision history for this message
Dan Wells (dbw2) wrote :

As it turns out, the missing oils_i18n_gettext() shouldn't matter, since it is only used during the 'make' step of the build process, and that never happens for upgrade scripts (if I understand the basics of what Pasi told me).

In any case, a lot of upgrade scripts have oils_i18n_gettext() in them, and it never hurts to be consistent, so I went ahead and pushed my "fix" anyway.

As for the original bug, thanks to Pasi, Ben, and Remington for pitching in on it. Four sign-offs on the fix for what was likely a find-and-replace error; I love it :)

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.