acq.user_request_type entries are not picked for translation

Bug #1160265 reported by Pasi Kallinen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.3
Fix Released
Undecided
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

*EG master

acq.user_request_type inserts have the oils_i18n_gettext() -marker, but as those inserts are not present in 950.data.seed-values.sql, they're not picked up into po-files for translation.

Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
Pasi Kallinen (paxed)
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.5.0-m2
Revision history for this message
Pasi Kallinen (paxed) wrote :

OK, the real fix is in user/paxed/lp1160265 - sorry about that.

tags: removed: pullrequest
Changed in evergreen:
milestone: 2.5.0-m2 → none
milestone: none → 2.5.0-m2
tags: added: pullrequest
Revision history for this message
Remington Steed (rjs7) wrote :

I did the basic test of running the SQL commands in question, and they work as expected. Otherwise, it is a simple enough change that I am confident it will work. Signed off and rebased to master. Thanks Pasi!

user/rsteed/lp1160265_acq_i18n_seed_data

Revision history for this message
Dan Wells (dbw2) wrote :

This works fine for me. Push to master, 2.4, and 2.3. Thanks again, Pasi and Remington.

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.