Evergreen

IDL2js needs locale support

Bug #1171875 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 2.5.0-alpha1
2.2
Won't Fix
Undecided
Unassigned
2.3
Won't Fix
Undecided
Unassigned
Evergreen 2.3.12
2.4
Fix Released
Undecided
Unassigned
Evergreen 2.4.2

Bug Description

Evergreen 2.2+. For reference see bug #1078596 and bug #1155611.

Many staff client UIs load the IDL via /IDL2js (mod_perl at OpenILS::WWW::IDL2js). It loads fm_IDL.xml directly from /openils/conf/fm_IDL.xml, which is not locale-aware. In theory, the solution is to load the locale-aware /openils/var/web/reports/fm_IDL.xml instead.

Pasi Kallinen (paxed)
tags: added: i18n staffclient
Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
Revision history for this message
Bill Erickson (berick) wrote :

I've pushed code to working/user/berick/lp1171875-IDL2js-locale-support

It adds support for loading a locale-aware fm_IDL.xml from /reports/fm_IDL.xml from within IDL2js.pm. It does this with an Apache subrequest. Results for full-IDL lookups are cached. Partial lookups are still/also supported, but not cached.

I have not tested this in conjunction with the staff client. If the client passes a valid Accept-Language header, it should all just work. In cases where it does not, we will either have to fix the header or pass a locale= CGI param directly in the HTML that loads IDL2js.

Note that a minor Apache configuration change is required. Testing appreciated. Will test more as I can.

Revision history for this message
Pasi Kallinen (paxed) wrote :

Works For Me. My signoff at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/paxed/lp1171875-IDL2js-locale-support-signoff

Pasi Kallinen (paxed)
tags: added: pullrequest
Pasi Kallinen (paxed)
tags: added: signedoff
Revision history for this message
Bill Erickson (berick) wrote :

Thanks for testing and signing off, Pasi. Just to confirm, did you test the staff client as well, for example, the patron registration interface?

Revision history for this message
Pasi Kallinen (paxed) wrote :

Patron registration was the one thing I explicitly tested, as that's the one our users noticed.

Revision history for this message
Bill Erickson (berick) wrote :

I've also pushed a commit to my original branch with upgrade (release) notes for the Apache configuration change required.

Revision history for this message
Ben Shum (bshum) wrote :

Marking as "won't fix" for 2.2 because we are outside the 2.2 support timeframe for non-security bug fixes.

Changed in evergreen:
milestone: none → 2.5.0-alpha1
Revision history for this message
Mike Rylander (mrylander) wrote :

I've picked the signed-off versions from Pasi's branch and Bill's release note update into master and rel_2_4. There are structural changes between 2.3 and 2.4 that are blocking simple backports, so because this is a feature-y bug fix I'm leaving it out of 2.3. However, if someone wants to work on the changes for 2.3 backport, be my guest.

Thanks, Bill for developing and Pasi for testing!

Changed in evergreen:
status: Triaged → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Bill Erickson (berick) wrote :

I also think this is too feature-y for 2.3. Marking as won't-fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.