Lack of visual feedback in bookmarks panel
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Midori Web Browser |
Fix Released
|
Wishlist
|
André Auzi |
Bug Description
When I do a selection in the bookmark tree view I expect to have some information feedbacked in the status bar.
The vital information for me is the number of Bookmarks present in a folder so I can choose whether or not I can open it in new Tabs.
I would also expect some visual hint of whether a bookmark is a web application or a regular bookmark.
For this specific point, I've checked the HIG and observed that the popup menus should actually reflect the behaviour of activate the depend on the 'show as web application' flag.
Instead of an 'Open' action that opens the bookmark either in the current view tab or as web application, we should have two distinct actions:
1- the 'Open' action that always does the opening in the current view and
2- something like 'Run as web application' action.
The two actions should be listed but their order should depend on the value of the 'show as web application' flag.
Related branches
- Cris Dywan: Approve
- André Auzi: Needs Resubmitting
- Paweł Forysiuk: Approve
-
Diff: 547 lines (+404/-10)4 files modifiedmidori/midori-array.c (+150/-0)
midori/midori-array.h (+7/-0)
midori/midori-browser.c (+15/-4)
panels/midori-bookmarks.c (+232/-6)
Changed in midori: | |
milestone: | none → 0.5.1 |
Changed in midori: | |
assignee: | nobody → André Auzi (aauzi) |
status: | New → In Progress |
importance: | Undecided → Wishlist |
Changed in midori: | |
status: | In Progress → Fix Committed |
Changed in midori: | |
status: | Fix Committed → Fix Released |
The attached patch implements most of the points listed:
1- a different icon for bookmarks shown as web application.
I'm not an icon designer so for the sake of the demonstration I've just picked GTK_STOCK_EXECUTE
2- the spilt in bookmark bar and the bookmarks panel of the Open and Run as web Application actions STOCK_EXECUTE is also used for the Run as web Application action.
GTK_
Note: To keep thinks coherent the patch changes the midori-view link popup menu the same way.
3- The reordering of these actions in the popup menu according the 'Show as web Application' flag value.
4- status bar text information on a selected item, showing:
* for a folder: the number of child bookmarks and folders
* for a bookmark: wether it is a web application or a regular bookmark and the bookmarked uri.