Tests depend on unittest2

Oh, and related: LP: #1097061

(but I agree with the above that a dependency on Twisted for testing is suboptimal)

Well, I have nothing against removing this dependency, but I fail to integrate "unittest" from Python 3.3 and "setuptools" ...

This is the problematic line in "setup.py":

    'test_suite': 'unittest2.collector.collector'

Any idea ?
Thanks.

On Jun 15, 2013, at 12:29 PM, Florent wrote:

>Well, I have nothing against removing this dependency, but I fail to
>integrate "unittest" from Python 3.3 and "setuptools" ...
>
>This is the problematic line in "setup.py":
>
> 'test_suite': 'unittest2.collector.collector'
>
>Any idea ?

Since all your tests live in the pyflakes.test subpackage, it should be enough
to just do this:

try:
    from setuptools import setup
except ImportError:
    from distutils.core import setup
    extra = {'scripts': ["bin/pyflakes"]}
else:
    if sys.version_info < (3,):
        extra = {'tests_require': ['unittest2'],
                 'test_suite': 'unittest2.collector'}
    else:
        ## extra = {'tests_require': ['unittest2py3k'],
        ## 'test_suite': 'unittest2.collector.collector'}
        extra = {'test_suite': 'pyflakes.test'}
    extra['entry_points'] = {
        'console_scripts': ['pyflakes = pyflakes.api:main'],
    }

After I changed all the imports from 'unittest2' to 'unittest', it all just
worked:

...
----------------------------------------------------------------------
Ran 544 tests in 0.467s

OK (skipped=33)

Thank you for this hint, Barry.

I dropped the test dependency for Python >= 2.7 (in revision 101).