missing a tc_control from a test directory results hard to decipher failure

Bug #1190671 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
UTAH
Fix Released
High
Andy Doan

Bug Description

I accidentally forgot to populate a test with a tc_control file and I got the following error:

+ sleep 2
+ utah -d -o /var/lib/utah/utah.yaml -r /home/phablet/examples/pass.run
2013-06-13 16:31:25,550 - DEBUG - Namespace(append=False, battery='software', debug=True, format='yaml', install_type='desktop', output='/var/lib/utah/utah.yaml', resume=False, runlist='/home/phablet/examples/pass.run', state_file=None, testdir='/var/lib/utah')
2013-06-13 16:31:25,558 - INFO - ('Linux', 'ubuntu-phablet', '3.4.0-1-mako', '#8-Ubuntu SMP PREEMPT Mon Jun 10 14:28:29 UTC 2013', 'armv7l', 'armv7l')
DEVELOPMENT
utah_tests_sample/idle_max_brightness/tc_control2013-06-13 16:31:25,950 - DEBUG - Running cleanup
+ [ -f /var/lib/utah/utah.yaml ]
+ python -c import xmlrpclib; s=xmlrpclib.ServerProxy('http://192.168.0.5:43455', allow_none=True); s.utah_done()
utah: completed /etc/utah/autorun/01_run-utah rc=0

..so I got a return code of zero (success??) and none of the other tests got run. Took me a while to figure out why it passed yet failed to run all my existing tests when I added a new test without a tc_control file.

Perhaps there should be some better sanity checking and error handling if users make dumb mistakes like I did.

Related branches

Revision history for this message
Andy Doan (doanac) wrote :

there are two parts to this bug:

1) the utah-client's error message stinks. its practically hidden:
  "utah_tests_sample/idle_max_brightness/tc_control"

I'm fixing this ASAP as well as a couple of others I've uncovered.

2) I need to dig a bit in my new phablet script. One part of the problem is that adb-shell always returns 0. but we should be able to figure out what's really happening.

Changed in utah:
assignee: nobody → Andy Doan (doanac)
importance: Undecided → High
milestone: none → 0.13
Revision history for this message
Andy Doan (doanac) wrote :

The client-error-messages helps with part 1 of the bug.

Revision history for this message
Andy Doan (doanac) wrote :

I just added a hack to my touch branch to deal with part 2 of the problem. I can now get errors from adb-shell and exit when needed. I just rebased on the latest utah and did a "bzr push --overwrite" for lp:~doanac/utah/touch. The specific commit needed to address this issue is:

  http://bazaar.launchpad.net/~doanac/utah/touch/revision/947

Changed in utah:
status: New → Fix Committed
Andy Doan (doanac)
Changed in utah:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.