run_utah_tests in trunk ignoring -s and -t options

Bug #1192637 reported by Andy Doan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
UTAH
Fix Released
Critical
Max Brustkern

Bug Description

The -s and -t options are being ignored because of the new function we've added:

def _get_unprovisioned_machine(args, image=None):
    if image is None:
        image = ISO(arch=args.arch, installtype=config.installtype, series=config.series)

we are passing config values rather than command line arg values. the fix is simple:

diff --git a/examples/run_utah_tests.py b/examples/run_utah_tests.py
index fe45b75..95529c3 100755
--- a/examples/run_utah_tests.py
+++ b/examples/run_utah_tests.py
@@ -52,8 +52,7 @@ except ImportError:

 def _get_unprovisioned_machine(args, image=None):
     if image is None:
- image = ISO(arch=args.arch, installtype=config.installtype,
- series=config.series)
+ image = ISO(arch=args.arch, installtype=args.type, series=args.series)
     kw = {'clean': (not args.no_destroy),
           'boot': args.boot,
           'debug': args.debug,

Andy Doan (doanac)
Changed in utah:
assignee: nobody → Max Brustkern (nuclearbob)
Revision history for this message
Max Brustkern (nuclearbob) wrote : Re: [Bug 1192637] [NEW] run_utah_tests in trunk ignoring -s and -t options

I realized this yesterday. It's fixed in the lvm branch I'm working on,
but if we're trying to release before that's ready, I can create a separate
patch for that.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

LVM won't be ready today, so I went ahead and pushed this fix.

Changed in utah:
status: New → Fix Committed
Andy Doan (doanac)
Changed in utah:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.