OpenSRF

silence some uninitialized warnings

Bug #1207464 reported by Jason Etheridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Undecided
Unassigned
OpenSRF 2.2.1

Bug Description

I've only noticed these in the context of running make livecheck in my collab/phasefx/livetests Evergreen branch:

Use of uninitialized value $2 in pattern match (m//) at /usr/local/share/perl/5.10.1/OpenSRF/Utils.pm line 268.

Use of uninitialized value in array dereference at /usr/local/share/perl/5.10.1/OpenSRF/DomainObject/oilsMethod.pm line 94.

Fixes are in collab/phasefx/warnings @ working/OpenSRF.git
http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/collab/phasefx/warnings

Jason Etheridge (phasefx)
tags: added: pullrequest
Jason Etheridge (phasefx)
tags: added: qaproject
Revision history for this message
Jason Etheridge (phasefx) wrote :

Hrmm, I'm returning an array ref but should probably return an array. Testing...

Changed in opensrf:
milestone: none → 2.2.1
tags: removed: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

Pushed a fix to collab/phasefx/warnings, and squashed them into one commit at collab/phasefx/warnings_squashed

tags: added: pullrequest
Revision history for this message
Jason Etheridge (phasefx) wrote :

And force-pushed that last branch again, this time with some tab/space consistency rolled into the single commit. :-/

Revision history for this message
Bill Erickson (berick) wrote :

Jason, I gave this a run through. My only concern is that the tests can only be run once per newly minted database, since the tests fail when a workstation already exists. One solution that worked for me was to call register workstation in override mode:

open-ils.actor.workstation.register.override

This will work regardless of whether the workstation exists. Alternatively, we could delete each workstation we create.

Or we could add a set of stock workstations to the seed data and use those instead of creating new ones for each test.

Revision history for this message
Bill Erickson (berick) wrote :

Haha, arg. Commented on wrong bug... That was meant for bug #1206531

Revision history for this message
Bill Erickson (berick) wrote :

This bug is just dandy. Tested and merged to master. Thanks, Jason.

Changed in opensrf:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.