View mode buttons don't respect button fg color

Bug #1211440 reported by Satyajit Sahoo
22
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Files
Fix Released
Low
Corentin Noël

Bug Description

The view mode buttons in pantheon files don't respect the button text color.

For example, even if the following is specified in the theme,

.button { color: @theme_fg_color; }

The symbolic icons in view mode buttons are light.

The only workaround seems to be,

* { color: @theme_fg_color; }

To reproduce the issue, remove the following part in gtk-widgets.css of egtk

* { color: @text_color; }

I've attached a screenshot using Numix theme.

Related branches

Revision history for this message
Satyajit Sahoo (satyajit-happy) wrote :
Revision history for this message
Danielle Foré (danrabbit) wrote :

Can confirm that it doesn't seem to respect ".button GtkImage"

Not sure if this is an issue in Granite or Files though

Changed in egtk:
status: New → Invalid
Revision history for this message
Victor Martinez (victored) wrote : Re: [Bug 1211440] [NEW] View mode buttons don't respect button fg color

This is not a bug in Granite either.

For anybody interested on fixing this bug in pantheon files, it is related
to the style context passed to the method that creates icon pixbufs. A
faster solution would be using Gtk.Image.set_from_gicon or
Gtk.Image.set_from_icon_name to render the icons.
On Aug 12, 2013 12:05 PM, "Satyajit Sahoo" <email address hidden>
wrote:

> Public bug reported:
>
> The view mode buttons in pantheon files don't respect the button text
> color.
>
> For example, even if the following is specified in the theme,
>
> .button { color: @theme_fg_color; }
>
> The symbolic icons in view mode buttons are light.
>
> The only workaround seems to be,
>
> * { color: @theme_fg_color; }
>
> To reproduce the issue, remove the following part in gtk-widgets.css of
> egtk
>
> * { color: @text_color; }
>
> I've attached a screenshot using Numix theme.
>
> ** Affects: egtk
> Importance: Undecided
> Status: New
>
> ** Affects: granite
> Importance: Undecided
> Status: New
>
> ** Affects: pantheon-files
> Importance: Undecided
> Status: New
>
> ** Attachment added: "view-mode.png"
>
> https://bugs.launchpad.net/bugs/1211440/+attachment/3769943/+files/view-mode.png
>
> ** Also affects: granite
> Importance: Undecided
> Status: New
>
> ** Also affects: egtk
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to
> Granite.
> Matching subscriptions: granite-bug-mail
> https://bugs.launchpad.net/bugs/1211440
>
> Title:
> View mode buttons don't respect button fg color
>
> Status in The elementary GTK Theme:
> New
> Status in Granite Framework:
> New
> Status in Files:
> New
>
> Bug description:
> The view mode buttons in pantheon files don't respect the button text
> color.
>
> For example, even if the following is specified in the theme,
>
> .button { color: @theme_fg_color; }
>
> The symbolic icons in view mode buttons are light.
>
> The only workaround seems to be,
>
> * { color: @theme_fg_color; }
>
> To reproduce the issue, remove the following part in gtk-widgets.css
> of egtk
>
> * { color: @text_color; }
>
> I've attached a screenshot using Numix theme.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/egtk/+bug/1211440/+subscriptions
>

Changed in pantheon-files:
status: New → Triaged
Changed in granite:
status: New → Invalid
Changed in pantheon-files:
importance: Undecided → Low
Revision history for this message
Alba Nader (sharepass12) wrote :

I encounter exactly the same. Although I am using dark icons everywhere else, Pantheon icons are white and thus hardly to see.

Changed in pantheon-files:
status: Triaged → Fix Committed
Cody Garver (codygarver)
Changed in pantheon-files:
milestone: none → isis-beta1
assignee: nobody → Corentin Noël (tintou)
no longer affects: granite
no longer affects: egtk
Changed in pantheon-files:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.