Evergreen

Money columns do not sort correctly in billing interface

Bug #1211506 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 2.5.0-alpha2
2.3
Fix Released
Medium
Unassigned
Evergreen 2.3.10
2.4
Fix Released
Medium
Unassigned
Evergreen 2.4.2

Bug Description

Confirmed in master; believed to be true for Evergreen 2.3+

In the patron billing UI in the staff client, money columns sort ascii-betically instead of numerically. That's not cool. Working on a patch...

Tags: staffclient
Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1211506-bill-ui-money-sorting

Somewhere along the way, sort values for numeric columns (number, money) are getting cast to Strings. This patch casts them back to Numbers during sorting.

Changed in evergreen:
assignee: Bill Erickson (erickson-esilibrary) → nobody
milestone: none → 2.5.0-alpha2
status: In Progress → New
Revision history for this message
Jason Etheridge (phasefx) wrote :

I pushed a squashed/signed-off branch to collab/phasefx/lp1211506-bill-ui-money-sorting

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1211506-bill-ui-money-sorting

Thanks Bill!

Revision history for this message
Jason Etheridge (phasefx) wrote :

One quick way to test:

In the staff client, pull up a user and add separate grocery bills for $11.00, $2.00, and $1.00. Click the Balance Owed column header to sort.

Revision history for this message
Ben Shum (bshum) wrote :

Thanks for the test steps Jason! Looks like a good fix to me, pushed to master, rel_2_4 and rel_2_3 for backport goodness too.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Medium
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.