oslo-incubator

service.py is broken on Windows due to SIGHUP addition

Bug #1217043 reported by Alessandro Pilotti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Alessandro Pilotti
Ceilometer 2013.2 "havana"
oslo-incubator
Fix Released
High
Alessandro Pilotti
oslo-incubator 2013.2 "havana"

Bug Description

The following commit added support for SIGHUP in "openstack/common/service.py"

https://github.com/openstack/oslo-incubator/commit/825ace5581fbb416944acae62f51c489ed93b9c9

Unfortunately, signal.SIGHUP is not supported on Windows, resulting in not being able to start a service on WIndows.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43752

Changed in oslo:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Mark McLoughlin (markmc)
Changed in oslo:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/43752
Committed: http://github.com/openstack/oslo-incubator/commit/11cc74f78cf7ed6b63ff7aebf6e63e28d44cfddb
Submitter: Jenkins
Branch: master

commit 11cc74f78cf7ed6b63ff7aebf6e63e28d44cfddb
Author: Alessandro Pilotti <email address hidden>
Date: Mon Aug 26 21:37:32 2013 +0300

    Fixes issue with SUGHUP in services on Windows

    Fixes bug: #1217043

    The signal module does not have a SIGHUP member on Windows. This
    commit adds conditional statements based on the platform to allow the
    execution of Oslo based services on Windows.

    Change-Id: Ic873ce2a3337b0832055b760607e58df92a3cead

Changed in oslo:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44961

Changed in ceilometer:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/44961
Committed: http://github.com/openstack/ceilometer/commit/11d2e2bb6228501e1b5874d2b7063bfc63c2e335
Submitter: Jenkins
Branch: master

commit 11d2e2bb6228501e1b5874d2b7063bfc63c2e335
Author: Alessandro Pilotti <email address hidden>
Date: Wed Sep 4 13:23:36 2013 +0300

    Fixes service startup issue on Windows

    A recent addition in Oslo to support SIGHUP created a blocking issue
    on Windows due to missing signal.SIGHUP support.

    Fixes bug: #1217043

    Change-Id: If530cdf8609655ef55aabbad95a2ec8b44ed8679

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → havana-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: havana-3 → 2013.2
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.