Mir will bypass shaped windows (those with an active alpha channel) when it shouldn't
Bug #1236264 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
Bug Description
Mir will bypass shaped windows (those with an active alpha channel) when it shouldn't.
At the moment, Mir doesn't check if a window has shape (alpha channel). This means fullscreen windows that actually use the alpha channel could get bypassed and spuriously stop everything behind them from rendering.
Related branches
lp://qastaging/~vanvugt/mir/shape
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
-
Diff: 493 lines (+149/-32)15 files modifiedexamples/eglapp.c (+43/-2)
examples/eglapp.h (+2/-0)
examples/eglflash.c (+11/-11)
examples/egltriangle.c (+1/-1)
include/server/mir/compositor/compositing_criteria.h (+1/-0)
include/shared/mir/geometry/pixel_format.h (+6/-0)
include/test/mir_test_doubles/mock_compositing_criteria.h (+1/-0)
include/test/mir_test_doubles/mock_surface_state.h (+1/-0)
include/test/mir_test_doubles/stub_compositing_criteria.h (+10/-2)
src/server/compositor/bypass.cpp (+1/-1)
src/server/surfaces/surface_allocator.cpp (+4/-1)
src/server/surfaces/surface_data.cpp (+7/-1)
src/server/surfaces/surface_data.h (+4/-1)
tests/unit-tests/compositor/test_bypass.cpp (+43/-0)
tests/unit-tests/surfaces/test_surface_data.cpp (+14/-12)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| milestone: | none → phone-v1-freeze |
| Changed in mir: | |
| milestone: | phone-v1-freeze → 0.0.14 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:~mir-team/mir/development-branch at revision 1113, scheduled for release in mir, milestone Unknown