Ceilometer

SqlAlchemy get_events can't return events without traits

Bug #1245992 reported by Andrew Melton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Andrew Melton
Ceilometer 2014.1 "icehouse"

Bug Description

Due to the join on Traits, and loading of events from their Traits, the current get_events implementation can't return Events that don't have any traits. If no Traits are provided in the filter, the get_events function should return all matching Events, event those Events with no Traits.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/54392

Changed in ceilometer:
assignee: nobody → Andrew Melton (andrew-melton)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/54392
Committed: http://github.com/openstack/ceilometer/commit/19c6cb1413a6615497ec0f7028b31f57c3107bd6
Submitter: Jenkins
Branch: master

commit 19c6cb1413a6615497ec0f7028b31f57c3107bd6
Author: Andrew Melton <email address hidden>
Date: Tue Oct 29 14:12:33 2013 -0400

    Allow Events without traits to be returned

    Due to the join with Traits done in the SqlAlchemy implementation
    of get_events, only Events with Traits can be returned from that
    call. This would be expected behavior if Traits are provided in
    the filter, but if no Traits are provided, all matching Events
    should be returned. Even those without Traits.

    The solution to this is to pre-populate the dictionary of Event
    models before populating their Traits in the case of no Trait
    filters being provided.

    Change-Id: I4b0a5c20952f1dd5f2e2db631ffe1a14bd168fb3
    Closes-Bug: #1245992

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.