extend plainbox loggers to also support checkbox_ng

Bug #1250358 reported by Sylvain Pineau
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Next Generation Checkbox (CLI)
Fix Released
Medium
Zygmunt Krynicki
PlainBox (Toolkit)
Fix Released
High
Zygmunt Krynicki

Bug Description

It's actually not possible to log the service module now living in checkbox_ng, only plainbox root loggers are defined in the logging config.

To debug checkbox.ng.commands.service, one needs to temporary rename it to something beggining with plainbox.

The plainbox loging fetaure should support extra root loggers to allow upper layers to use it super logging options.

Tags: mentoring

Related branches

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is quite true. I think it would be great to patch the logging helper classes to include a parameter that defines the "root" location or perhaps make them work on the root logger (so they would apply anywhere). What do you think?

Zygmunt Krynicki (zyga)
Changed in checkbox:
status: New → Triaged
importance: Undecided → Medium
tags: added: mentoring
Zygmunt Krynicki (zyga)
Changed in checkbox:
milestone: none → plainbox-0.5
Zygmunt Krynicki (zyga)
Changed in checkbox:
importance: Medium → High
assignee: nobody → Zygmunt Krynicki (zkrynicki)
milestone: plainbox-0.5 → plainbox-0.6
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This affects plainbox (improved log management functions and chcekbox-ng, to actually use them)

Changed in plainbox:
milestone: none → 0.6
Changed in checkbox:
milestone: plainbox-0.6 → none
Changed in plainbox:
assignee: nobody → Zygmunt Krynicki (zkrynicki)
Changed in checkbox-ng:
milestone: none → future
Changed in plainbox:
importance: Undecided → High
status: New → Triaged
Zygmunt Krynicki (zyga)
no longer affects: checkbox
Zygmunt Krynicki (zyga)
tags: removed: plainbox
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is now fixed with the rewritten checkbox-ng

Changed in checkbox-ng:
status: New → In Progress
Changed in plainbox:
status: Triaged → In Progress
Changed in checkbox-ng:
assignee: nobody → Zygmunt Krynicki (zkrynicki)
milestone: future → 0.4
importance: Undecided → Medium
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

The plainbox side is now proposed for merging. The checkbox-ng side is a little bit more complicated as it's entangled in the rewrite of checkbox-ng that is in progress.

Zygmunt Krynicki (zyga)
Changed in plainbox:
status: In Progress → Fix Committed
Zygmunt Krynicki (zyga)
Changed in checkbox-ng:
status: In Progress → Fix Committed
Daniel Manrique (roadmr)
Changed in checkbox-ng:
status: Fix Committed → Fix Released
Changed in plainbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.