Useless asserts in __init__ files
Bug #1251546 reported by
Radomir Dopieralski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Dashboard (Horizon) |
Fix Released
|
Low
|
Radomir Dopieralski | ||
Bug Description
In many __init__.py files in Horizon there is code that looks like this:
from horizon.base import Dashboard # noqa
from horizon.base import Panel # noqa
from horizon.base import PanelGroup # noqa
# silence flake8 about unused imports here:
assert Dashboard
assert Panel
assert PanelGroup
This breaks when the imports are optional, and would be much better done by defining __all__ with the relevant names.
| Changed in horizon: | |
| assignee: | nobody → Radomir Dopieralski (thesheep) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to horizon (master) | #1 |
| Changed in horizon: | |
| status: | New → In Progress |
| Changed in horizon: | |
| importance: | Undecided → Low |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to horizon (master) | #2 |
| Changed in horizon: | |
| status: | In Progress → Fix Committed |
| Changed in horizon: | |
| milestone: | none → icehouse-2 |
| status: | Fix Committed → Fix Released |
| Changed in horizon: | |
| milestone: | icehouse-2 → 2014.1 |
To post a comment you must log in.
Fix proposed to branch: master
Review: https:/