Implement initial conditional layout framework
Bug #1253761 reported by
Victor Thompson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Music App |
Fix Released
|
Medium
|
Andrew Hayzen | ||
Bug Description
In order to properly implement app design for multiple form factors, such as vertical and horizontal tablet views, and desktop mode, the Ubuntu Layouts' ConditionalLayout component [1] needs to be used.
[1] http://
Related branches
lp://qastaging/~ahayzen/music-app/refactor-pull-now-playing-sidebar
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Andrew Hayzen: Needs Information
-
Diff: 385 lines (+152/-11)15 files modifiedapp/components/MusicPage.qml (+45/-4)
app/components/NowPlayingSidebar.qml (+60/-0)
app/components/NowPlayingToolbar.qml (+2/-0)
app/components/Queue.qml (+4/-2)
app/music-app.qml (+29/-3)
app/ui/AddToPlaylist.qml (+1/-0)
app/ui/Albums.qml (+1/-0)
app/ui/ArtistView.qml (+1/-0)
app/ui/Artists.qml (+1/-0)
app/ui/Genres.qml (+1/-0)
app/ui/Playlists.qml (+1/-0)
app/ui/Recent.qml (+1/-0)
app/ui/Songs.qml (+1/-0)
app/ui/SongsView.qml (+3/-2)
debian/changelog (+1/-0)
lp://qastaging/~ahayzen/music-app/convergence-tabs-with-sidebar-01
- Victor Thompson: Approve
- Jenkins Bot: Approve (continuous-integration)
-
Diff: 2029 lines (+1077/-432)26 files modifiedapp/components/BlurredBackground.qml (+3/-1)
app/components/Flickables/MusicGridView.qml (+0/-10)
app/components/HeadState/EmptyHeadState.qml (+56/-0)
app/components/HeadState/MultiSelectHeadState.qml (+89/-76)
app/components/HeadState/PlaylistHeadState.qml (+78/-0)
app/components/HeadState/PlaylistsHeadState.qml (+54/-20)
app/components/HeadState/QueueHeadState.qml (+89/-0)
app/components/HeadState/SearchHeadState.qml (+59/-46)
app/components/HeadState/SearchableHeadState.qml (+45/-8)
app/components/MusicPage.qml (+39/-0)
app/components/NowPlayingFullView.qml (+76/-68)
app/components/NowPlayingSidebar.qml (+134/-0)
app/components/NowPlayingToolbar.qml (+18/-14)
app/components/Queue.qml (+5/-1)
app/music-app.qml (+101/-23)
app/ui/AddToPlaylist.qml (+5/-2)
app/ui/Albums.qml (+5/-2)
app/ui/ArtistView.qml (+12/-2)
app/ui/Artists.qml (+5/-2)
app/ui/ContentHubExport.qml (+34/-26)
app/ui/Genres.qml (+5/-2)
app/ui/NowPlaying.qml (+113/-77)
app/ui/Playlists.qml (+5/-2)
app/ui/Recent.qml (+41/-15)
app/ui/SongsView.qml (+5/-35)
debian/changelog (+1/-0)
| Changed in music-app: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Andrew Hayzen (andrew-hayzen) |
Revision history for this message
| Andrew Hayzen (ahayzen) wrote | #1 |
| Changed in music-app: | |
| milestone: | none → 2.0 |
Revision history for this message
| David Planella (dpm) wrote | #2 |
| Changed in music-app: | |
| importance: | High → Medium |
| Changed in music-app: | |
| status: | Triaged → In Progress |
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | #3 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This will be fully implemented in the remix by using the new views to fill the screen better. Therefore targeting for v2 milestone.