oslo-incubator

groups should be in order in the output of config/generate.py

Bug #1258363 reported by Lianhao Lu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
JunJie Nan
OpenStack Heat 2014.1 "icehouse"
oslo-incubator
Fix Released
Medium
Lianhao Lu
oslo-incubator 2014.1 "icehouse"

Bug Description

Currently, the output generated by openstack/common/config/generate.py may change a lot if new opt groups are added. This is because it doesn't sort the output by group names.

for group, opts in opts_by_group.items():
        print_group_opts(group, opts)

The dict.items() don't order the result it returned.

Lianhao Lu (lianhao-lu)
Changed in oslo:
assignee: nobody → Lianhao Lu (lianhao-lu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60401

Changed in oslo:
status: New → In Progress
Revision history for this message
Matt Riedemann (mriedem) wrote :

An example of where this is happening is the nova patch here: https://review.openstack.org/#/c/35765/

There was a new metrics group added with two options and it totally changed the nova.conf.sample file.

Ben Nemec (bnemec)
Changed in oslo:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/60401
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=4b3e32b980cf1d028da9325b21183ff635fbe043
Submitter: Jenkins
Branch: master

commit 4b3e32b980cf1d028da9325b21183ff635fbe043
Author: Lianhao Lu <email address hidden>
Date: Fri Dec 6 10:30:56 2013 +0800

    Sort the output of config/generator.py by group name

    Sort the output of config/generator.py by group name(except the DEFAULT
    group) to avoid huge changes in the output when adding new oslo.cfg
    option group.

    Closes-Bug: 1258363
    Change-Id: I28d767e13a7b0fce4dafa1dd051779e1b1cbba86

Changed in oslo:
status: In Progress → Fix Committed
JunJie Nan (nanjj)
Changed in heat:
assignee: nobody → JunJie Nan (nanjj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64500

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/64500
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1bcc65762f664c283a9dd6f2731199a6c873c641
Submitter: Jenkins
Branch: master

commit 1bcc65762f664c283a9dd6f2731199a6c873c641
Author: JUN JIE NAN <email address hidden>
Date: Tue Dec 31 12:41:17 2013 +0800

    Sort the output of config/generator.py by group name

    To avoid huge changes in the output when adding new option groups.

    Sync from oslo commit 4b3e32b980cf1d028da9325b21183ff635fbe043.

    Closes-Bug: #1258363

    Change-Id: I9173a38d4d548ce641e19ada30f86148c1f0c53f

Changed in heat:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in oslo:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in heat:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-2 → 2014.1
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.