residual dump files left from 012 migration

Bug #1259724 reported by gordon chung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
gordon chung

Bug Description

we have dump_xyz tables remaining after 012 migration upgrade? do we really need to have a bunch of backup tables to exists post-migration?

explanation from Svetlana:
Guys, my point was:
we had found some of foreign keys declared in models and skipped in database. There was a little chance that we can get a problem in that. If there are some data in table (where foreign key should be declared) that skipped in reference table migration will be failed. We couldn't delete all data in tables that can fail maintain the integrity of reference. So, deleting data in a migration should be done with care, clearly communicated to users, and the data should be logged so that it can be recreated by user if necessary. It was done by backup tables, where all conflicted data were placed.

bug question:
if the integrity of data is invalid should we even keep it? if the foreign key was there from the beginning like it should've been, the unmappable data wouldn't be there to begin with no?

 see: https://bugs.launchpad.net/ceilometer/+bug/1204823

Revision history for this message
gordon chung (chungg) wrote :

i guess the second comment i have is, most people with data with some importance would back up before ever migrating so the backup tables are of very little use.

Changed in ceilometer:
importance: Undecided → Low
Julien Danjou (jdanjou)
Changed in ceilometer:
milestone: none → icehouse-rc1
status: New → Triaged
gordon chung (chungg)
Changed in ceilometer:
assignee: nobody → gordon chung (chungg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/83657

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/83657
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=d0ff5ff7857d9e4de6cce1e07e208e34b4464682
Submitter: Jenkins
Branch: master

commit d0ff5ff7857d9e4de6cce1e07e208e34b4464682
Author: Gordon Chung <email address hidden>
Date: Thu Mar 27 09:29:29 2014 -0400

    remove dump tables from previous migrations

    dump tables from 012 and 027 migrations should really be handled
    by DBAs. creating additional dump tables just consumes unnecessary
    space.

    Change-Id: I3a8716627c2f52a1a3c59f36009d8265ac96a0fa
    Closes-Bug: #1259724

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.