Ceilometer

Wrong env var in oslo.config.generator.rc

Bug #1262331 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
Lianhao Lu
Ceilometer 2014.1 "icehouse"

Bug Description

As pointed out in the nova oslo sync review here:

https://review.openstack.org/#/c/62815/

The env var in tools/config/oslo.config.generator.rc should be using the same name that the generator.py code is using, which is project specific.

For ceilometer, that's defined here:

https://github.com/openstack/ceilometer/blob/master/ceilometer/openstack/common/config/generator.py#L80

And the value is "CEILOMETER_CONFIG_GENERATOR_EXTRA_MODULES", which doesn't match what's in oslo.config.generator.rc so that code doesn't work.

Looks like the problem originated with this patch: https://review.openstack.org/#/c/45886/

Matt Riedemann (mriedem)
tags: added: low-hanging-fruit
Lianhao Lu (lianhao-lu)
Changed in ceilometer:
assignee: nobody → Lianhao Lu (lianhao-lu)
importance: Undecided → Low
milestone: none → icehouse-2
status: New → Confirmed
Revision history for this message
Lianhao Lu (lianhao-lu) wrote :

It used to be working in ceilometer. But https://review.openstack.org/57498 broke it. We need to adapt to the new change.

Revision history for this message
Lianhao Lu (lianhao-lu) wrote :

Oops, sorry, it's not https://review.openstack.org/57498, it's the https://review.openstack.org/53912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63046

Changed in ceilometer:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/63046
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=7d1164d28dba79aaa6e398a097dabebd3cb7c403
Submitter: Jenkins
Branch: master

commit 7d1164d28dba79aaa6e398a097dabebd3cb7c403
Author: Lianhao Lu <email address hidden>
Date: Thu Dec 19 11:53:08 2013 +0800

    Correct env variable in file oslo.config.generator.rc

    Use CEILOMETER_CONFIG_GENERATOR_EXTRA_MODULES as the environment
    variable to include keystoneclient middleware's option in the config
    generator's output.

    Change-Id: Ibddeb587b22a0569dcb8db58d7cd8626b4482cb6
    Closes-Bug: 1262331

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.