Ceilometer

i18n support is broken in notification and publisher.rpc module

Bug #1263711 reported by ZhiQiang Fan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
ZhiQiang Fan
Ceilometer 2014.1 "icehouse"

Bug Description

when i read the source code of ceilometer, i found that there are some log messages don't support i18n,

./notification.py:76: LOG.debug('loading event definitions')
./notification.py:151: LOG.debug('Saving event "%s"', event.event_type)
./publisher/rpc.py:255: LOG.warn("Failed to publish %s samples, queue them",
./publisher/rpc.py:259: LOG.warn("Failed to publish %d samples, dropping them",

there is a commit in Dec 3: https://review.openstack.org/#/c/54683 , but new log is introduced in later commits.

ZhiQiang Fan (aji-zqfan)
Changed in ceilometer:
assignee: nobody → ZhiQiang Fan (aji-zqfan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/63777

Changed in ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/63777
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=bcac7d17b8da20a6a0e0041a0d1eae40b43023be
Submitter: Jenkins
Branch: master

commit bcac7d17b8da20a6a0e0041a0d1eae40b43023be
Author: ZhiQiang Fan <email address hidden>
Date: Mon Dec 23 23:23:05 2013 +0800

    Fix broken i18n support

    In notification and publisher.rpc module, there are some log messages
    don't support i18n, this patch fixes them.

    NOTE: rename unused variable from _ to n, because it will overshadow
    global _ of gettext.

    Change-Id: Ic703fe6536234f4d51a84f4a3b2e04049ec6f3b5
    Closes-Bug: #1263711

Changed in ceilometer:
status: In Progress → Fix Committed
gordon chung (chungg)
Changed in ceilometer:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.