config registry protocol in modules/glance/manifests/api.pp

Bug #1266988 reported by Liping Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-glance
Fix Released
Undecided
Liping Mao

Bug Description

We can config registry ip and port , modules/glance/manifests/api.pp. But we can't config the registry protocol.
If glance-registry is behind ssl proxy, we may need to config this.

What about add registry_protocol?
class glance::api(
...
  $registry_host = '0.0.0.0',
  $registry_port = '9191',
+ $registry_protocol = 'http',
...
)
...
  # configure api service to connect registry service
  glance_api_config {
    'DEFAULT/registry_host': value => $registry_host;
    'DEFAULT/registry_port': value => $registry_port;
+ 'DEFAULT/registry_client_protocol': value => $registry_protocol;
  }

  glance_cache_config {
    'DEFAULT/registry_host': value => $registry_host;
    'DEFAULT/registry_port': value => $registry_port;
+ 'DEFAULT/registry_client_protocol': value => $registry_protocol;
  }

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100410

Changed in puppet-glance:
assignee: nobody → Liping Mao (limao)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/100410
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=7f439210b1197efc55ec148074a598b1cb1e3816
Submitter: Jenkins
Branch: master

commit 7f439210b1197efc55ec148074a598b1cb1e3816
Author: Liping Mao <email address hidden>
Date: Tue Jun 17 11:59:39 2014 +0800

    Glance registry protocol should be configurable

    registry_client_protocol can't be configure in puppet now.
    The default value is "http". It should be configurable.

    Change-Id: I526c0892d123067362ea1b18cb8c21526a860981
    Closes-bug: #1266988

Changed in puppet-glance:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-glance:
milestone: none → 5.0.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/168218

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (stable/icehouse)

Reviewed: https://review.openstack.org/168218
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=e672c03a9a4d8fd29995b0a7e7f7aa18bdaaaf27
Submitter: Jenkins
Branch: stable/icehouse

commit e672c03a9a4d8fd29995b0a7e7f7aa18bdaaaf27
Author: Liping Mao <email address hidden>
Date: Tue Jun 17 11:59:39 2014 +0800

    Glance registry protocol should be configurable

    registry_client_protocol can't be configure in puppet now.
    The default value is "http". It should be configurable.

    Change-Id: I526c0892d123067362ea1b18cb8c21526a860981
    Closes-bug: #1266988
    (cherry picked from commit 7f439210b1197efc55ec148074a598b1cb1e3816)

tags: added: in-stable-icehouse
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.