Fuel for OpenStack

Fix mysql::python usage for spec tests

Bug #1270807 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Bogdan Dobrelya
Fuel for OpenStack 4.1

Bug Description

E.g. for puppet Keystone module tests are failed, see:
http://pastebin.com/msEHkZ4N
(45 examples, 12 failures,
should be: 45 examples, 0 failures)

The fix is
1)to use mysql::bindings::python everywhere since mysql::python was deprecated by 01/01/2014 (see https://github.com/puppetlabs/puppetlabs-mysql/commit/c22e72a97a4665a17178f358db72c73c3a5c70db)

 OR (upstream modules use this way, see https://bugs.launchpad.net/puppet-openstack/+bug/1271168 as example)

2)to limit the puppet-mysql version to <1.0.0 in Modulefiles, as well as use ref: 'origin/0.x' for puppet-mysql repos in .fixtures.yml
e.g. for puppet-keystone's upstream:
https://github.com/stackforge/puppet-keystone/blob/master/Modulefile#L12
https://github.com/stackforge/puppet-keystone/blob/master/.fixtures.yml#L8

(We should use the same way as upstream do)

See original description
Tags: library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/67821

Changed in fuel:
status: Triaged → In Progress
Bogdan Dobrelya (bogdando)
summary: - Fix puppet-keystone tests
+ Fix mysql::python usage for spec tests
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/68156

Bogdan Dobrelya (bogdando)
description: updated
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

The priority was set as 'low' because this issue affects only tests for puppet modules we use in Fuel and all of them have to be synced with puppet- stackforge upstream (tests we have now are broken and outdated heavily as well as modules themselves)

Changed in fuel:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/68156
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=7a0da6f69eb7e2933959e9a8160716c694f6fa94
Submitter: Jenkins
Branch: master

commit 7a0da6f69eb7e2933959e9a8160716c694f6fa94
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Jan 21 17:07:01 2014 +0200

    Limit puppet-mysql module version from the top

    Since mysql::python was deprecated by 01/01/2014
    (see https://github.com/puppetlabs/puppetlabs-mysql/
    commit/c22e72a97a4665a17178f358db72c73c3a5c70db)
    all puppet modules' dependencies and spec's fixtures
    relying on puppetlabs-mysql module/repo would fail, if
    mysql::python is used as is in Fuel now, thus should be
    fixed approrpiately, i.e.:
    1) limit mysql dependencies in Modulefiles to <1.0.0
    according to their upstream versions
    (see https://bugs.launchpad.net/puppet-openstack/+bug/1271168)
    2) add "ref: 'origin/0.x'" for mysql repos in .fixtures.yml

    Closes-bug: #1270807

    Change-Id: I28a0de33b6b749eb7f0270af02c4b369a032a13e
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.