DrawingContext, all ct to dc
Bug #1272073 reported by
David Mathog
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Inkscape |
Fix Released
|
Wishlist
|
David Mathog | ||
Bug Description
In various sections of the code DrawingContext objects were given the name "ct", which was confusing because within the same source modules the name "ct" was also used for cairo_t variables. The attached patch changes all DrawingContext "ct" (or "_ct" ) to "dc" (or "_dc") . Additionally the few instances of "bgct" where changed to "bgdc".
This should have no effect whatsoever on the compiled code, but it is less confusing when working in those modules since after the patch each name is only ever used for one data type.
Related branches
Revision history for this message
| David Mathog (mathog) wrote | #1 |
Revision history for this message
| su_v (suv-lp) wrote | #2 |
| Changed in inkscape: | |
| importance: | Undecided → Wishlist |
| milestone: | none → 0.91 |
Revision history for this message
| jazzynico (jazzynico) wrote | #3 |
| Changed in inkscape: | |
| assignee: | nobody → David Mathog (mathog) |
| status: | New → In Progress |
| tags: | added: code-quality |
| tags: |
added: code-design removed: code-quality |
Revision history for this message
| su_v (suv-lp) wrote | #4 |
| Changed in inkscape: | |
| status: | In Progress → Fix Committed |
| Changed in inkscape: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
On 2014-01-23 22:16 +0100, mathog wrote on 'inkscape-devel':
> If somebody could verify that it works on a Mac (…)
r12975+ patch compiled successfully on OS X 10.7.5 [1].
--
[1] tested with llvm-gcc-4.2 and with (outdated) clang from Xcode 4.3.2 on OS X 10.7.5
Note that for tests with newer clang from latest Xcode 5.0.2 on current OS X 10.9 Mavericks (uses libc++ instead of libstcd++), in case of build breakage, we'll have for now to rely e.g. on feedback provided by the port maintainer of the inkscape-devel port in MacPorts (and the build result of the MacPorts build-bots), once the changes have been committed to trunk.