OpenStack Dashboard (Horizon)

modal missing close and cancel button

Bug #1273874 reported by Cindy Lu on 2014-01-28

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Dmitry Tantsur	OpenStack Dashboard (Horizon) 2014.1 "icehouse"

Bug Description

Not sure if it's just me or what but some of the modal popup forms are missing the 'X' and 'Cancel' buttons.

This regression can been seen on Admin > Flavor > Edit Flavor and Project > Instances > Launch Instance. Modals with workflow tabs. Please see attached image.

Tags:

Revision history for this message

Cindy Lu (clu-m) wrote on 2014-01-28:

012814 - missing cancel button.png Edit (95.4 KiB, image/png)

Victoria Martinez de la Cruz (vkmc) on 2014-01-29

Changed in horizon:
status:	New → Confirmed
assignee:	nobody → Victoria Martínez de la Cruz (vkmc)

Victoria Martinez de la Cruz (vkmc) on 2014-01-29

tags:

added: low-hanging-fruit

Revision history for this message

Victoria Martinez de la Cruz (vkmc) wrote on 2014-02-03:

This seems to happen in workflows only.

Revision history for this message

Cindy Lu (clu-m) wrote on 2014-02-03:

Hi Victoria,

Yes, that is what I noticed too. :)

Revision history for this message

Vahid Hashemian (vahidhashemian) wrote on 2014-02-03:

I compiled a list of places I've seen the Cancel button missing in another bug, which I'll mark as duplicate of this bug shortly.
Anyway, here's the list:

Project -> Instances -> +Launch Instance / Edit Instance / Edit Security Group / Resize Instance
- Admin -> Instances -> Edit Instance
- Admin -> Flavors -> +Create Flavor / Edit Flavor / Modify Access
- Admin -> Defaults -> Update Defaults
- Admin -> Projects -> +Create Project / Modify Users / Edit Project / Modify Quota

It would be great if it can be added in these other places too :)

Revision history for this message

Cindy Lu (clu-m) wrote on 2014-02-03:

Thanks Vahid, that's great!

Revision history for this message

Victoria Martinez de la Cruz (vkmc) wrote on 2014-02-04:

Thanks Vahid and Cindy!

Julie Pichon (jpichon) on 2014-02-12

Changed in horizon:
importance:	Undecided → Medium

Victoria Martinez de la Cruz (vkmc) on 2014-02-15

Changed in horizon:
assignee:	Victoria Martínez de la Cruz (vkmc) → nobody

Sphoorti (sphoorti-joglekar) on 2014-02-17

Changed in horizon:
assignee:	nobody → Sphoorti (sphoorti-joglekar)

Revision history for this message

Dmitry Tantsur (divius) wrote on 2014-02-19:

Anyone working on this now? I already have a patch, sorry, didn't notice this bug is assigned

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-19: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/74654

Changed in horizon:
assignee:	Sphoorti (sphoorti-joglekar) → Dmitry "Divius" Tantsur (divius)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-02-20: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/74654
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=07be8681561435202813ec5d76d2ed03968bf649
Submitter: Jenkins
Branch: master

commit 07be8681561435202813ec5d76d2ed03968bf649
Author: Dmitry Tantsur <email address hidden>
Date: Wed Feb 19 05:27:52 2014 -0500

Always pass 'modal' context variable to workflow template

    Workflow templates rely on 'modal' context variable to be true for
    modal dialogs. Still, when rendering from WorkflowView,
    this variable is missing. This causes e.g. absent cancel and close
    buttons in flavor creating dialog (and also affects Tuskar UI).

Change-Id: I76b1f0b97c14280db7cb880651e663147103438f
Closes-Bug: #1273874