OpenStack Dashboard (Horizon)

Flavor Access settings lost between edits

Bug #1276371 reported by Nicolas Simonds
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Nicolas Simonds
OpenStack Dashboard (Horizon) 2014.1 "icehouse"
Havana
Fix Released
Undecided
Nicolas Simonds
OpenStack Dashboard (Horizon) 2013.2.3

Bug Description

Public / Flavor Access controls seem to be bugged.

To reproduce:

# Create a flavor, ignore the "Flavor Access" tab
# Watch the flavor get created with "Public" access
# Click "Edit", go to "Flavor Access", set it to a project or two
# Click Save
# Watch the access get switched to "Not Public"
# Click "Edit", go back to "Flavor Access"
# See that all flavors have disappeared
# Click "Save", and watch the access go back to "Public"

Expected Behaviour:

Flavor Access / Public settings are preserved between edits

Actual Behaviour:

All Flavor Access settings are lost between edits, and unless explicitly preserved, an edit can inadvertently make a private flavor public.

Matthias Runge (mrunge)
Changed in horizon:
milestone: none → icehouse-3
Revision history for this message
Nicolas Simonds (nicolas.simonds) wrote :

Do these no longer auto-link?

https://review.openstack.org/71146

Changed in horizon:
assignee: nobody → Nicolas Simonds (nicolas.simonds)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/71315

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/71146
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4100a1cbc24184b58d5049dfb601b18e29e6107d
Submitter: Jenkins
Branch: master

commit 4100a1cbc24184b58d5049dfb601b18e29e6107d
Author: Nicolas Simonds <email address hidden>
Date: Tue Feb 4 15:15:29 2014 -0800

    Don't copy the flavorid when updating flavors

    The Nova API makes the implicit assumption that flavorids are unique,
    so if one creates two flavors with the same flavorid, subsequent
    requests for flavor information can vary between "inaccurate" and
    "wildly f*cking inaccurate"

    From an end-user perspective, it makes it look like data such as
    flavor access settings get lost between edits (because the API pulls
    the access list from the wrong flavor)

    Let the API assign a new flavorid on changes. The comments around
    the handler code imply that is the desired behaviour, anyhow.

    Change-Id: I5403202396a7b136b0ae8637d6aae1cf32550747
    Closes-Bug: 1276371

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Akihiro Motoki (amotoki)
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/havana)

Reviewed: https://review.openstack.org/71315
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b2259b352fd1e00a269b8275afa8093223598235
Submitter: Jenkins
Branch: stable/havana

commit b2259b352fd1e00a269b8275afa8093223598235
Author: Nicolas Simonds <email address hidden>
Date: Tue Feb 4 15:15:29 2014 -0800

    Don't copy the flavorid when updating flavors

    The Nova API makes the implicit assumption that flavorids are unique,
    so if one creates two flavors with the same flavorid, subsequent
    requests for flavor information can vary between "inaccurate" and
    "wildly f*cking inaccurate"

    From an end-user perspective, it makes it look like data such as
    flavor access settings get lost between edits (because the API pulls
    the access list from the wrong flavor)

    Let the API assign a new flavorid on changes. The comments around
    the handler code imply that is the desired behaviour, anyhow.

    Cherry-picked from 4100a1cbc24184b58d5049dfb601b18e29e6107d

    Change-Id: I5403202396a7b136b0ae8637d6aae1cf32550747
    Closes-Bug: 1276371

tags: added: in-stable-havana
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.